Create get_gpos module, implement get-folder command, and add some module helper functions

[Marshall-Hallenbeck]

I was initially going to have the get_gpos module have the ability to download all of them, hence the helper functions, but LDAP can only query certain GPO information, so it'd have to be another SMB module to download them all; however, the user can just take the GUID output from the module and pass it to --get-folder

get_gpos module:

--get-folder feature:

[NeffIsBack]

Would it be possible to detect a folder on a remote system? Than we could just integrate it into the existing get commands

[Marshall-Hallenbeck]

Would it be possible to detect a folder on a remote system? Than we could just integrate it into the existing get commands

Well the current get-file command references a file, so what would we change it to? I think having them separate makes more sense.

[NeffIsBack]

Would it be possible to detect a folder on a remote system? Than we could just integrate it into the existing get commands

Well the current get-file command references a file, so what would we change it to? I think having them separate makes more sense.

Hmm yeah i was thinking about moving --get-file/--put-file maybe to --get/--put anyway and add some sort of deprecation warning for the old function. But of course that would only make sense if it is possible to do a smart download/upload. Thoughts?

[Marshall-Hallenbeck]

just using the verbs "get" and "put" doesn't make it clear what you are getting or putting, so it's sorta confusing, and honestly, changing all that code to just make it a single call sounds like a huge pain in the ass that I'm not interested in doing lol

[NeffIsBack]

just using the verbs "get" and "put" doesn't make it clear what you are getting or putting, so it's sorta confusing, and honestly, changing all that code to just make it a single call sounds like a huge pain in the ass that I'm not interested in doing lol

I mean we are on SMB, imo its pretty clear what you are trying to achieve. But if it cant be changed by a fairly simple check or try&except call its fine i guess. I just try to limit the amount of options the smb protocol has, there are already a lot (too much imo)

[Marshall-Hallenbeck]

I mean we are on SMB, imo its pretty clear what you are trying to achieve

Well I disagree with that... we have numerous options to get things such as users, groups, disks, computers, etc all under the SMB protocol.

[NeffIsBack]

Tried to request a non valid folder, imo that should be handled with a proper message:

Rest looks good so far:

[NeffIsBack]

I mean we are on SMB, imo its pretty clear what you are trying to achieve

Well I disagree with that... we have numerous options to get things such as users, groups, disks, computers, etc all under the SMB protocol.

That is true but it is still listed in the Options for put and get remote files. Also the options have descriptions & we have a wiki. Imo that should be enough, but if its not possible it doesnt matter anyway :D

[NeffIsBack]

why the heck did i/it close it lol

[NeffIsBack]

The get_gpos module LGTM:

When i try to get a folder inside other folders the path where it is stored is bugged. In the example i would assume that the folder subfolder is stored to the destination subfolder. However, the result is subfolder/FULLPATH/...

Also imo "recursive" download should always the default for folders, but that's just my opinion, thoughts?

[Marshall-Hallenbeck]

Also imo "recursive" download should always the default for folders, but that's just my opinion, thoughts?

Yeah that makes sense, but how many levels recursive?

[NeffIsBack]

Also imo "recursive" download should always the default for folders, but that's just my opinion, thoughts?

Yeah that makes sense, but how many levels recursive?

My intuition would always be, that --get-folder would get the folder and all its contents. So i guess indefinitely (until the OS rejects files because of no space lol). Similar to i would copy&paste it in the file explorer