fix(auth): return out of auth api route functions #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ode or other auth errors are encountered
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
potts99
approved these changes
Sep 27, 2024
|
thanks man 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
return out of auth api route functions when a 401 status code or other auth errors are encountered.
Essentially the isAdmin check would return the correct HTTP header, but still execute the rest of the code just fine. Returning the
reply.code()andreply.send()statements (wherever there is more code below them) fixes this behaviour.This fixes the issue mentioned here: #258