add: option to disable node-libsamplerate usage

This commit allows to disable "node-libsamplerate" usage when impossible to use it.
PerformanC · May 20, 2024 · d8da381 · d8da381
1 parent 257a116
commit d8da381
Show file tree

Hide file tree

Showing 3 changed files with 23 additions and 11 deletions.
diff --git a/README.md b/README.md
@@ -44,6 +44,9 @@ $ npm i
 > [!NOTE]
 > If you want to use pure JavaScript, replace `sodium-native` with `libsodium-wrappers`. Keep in mind that pure JavaScript will offer a worse performance.
 
+> [!NOTE]
+> If you are incapable of installing `node-libsamplerate`, remove its dependency from `package.json` and disable `nativePlayback` in `config.js`.
+
 ### 3. Run NodeLink
 
 ```shell

diff --git a/config.js b/config.js
@@ -16,7 +16,8 @@ export default {
     maxSearchResults: 200,
     maxAlbumPlaylistLength: 200,
     maxCaptionsLength: 3,
-    logFile: 'logs.txt'
+    logFile: 'logs.txt',
+    nativePlayback: true
   },
   debug: {
     youtube: {

diff --git a/src/voice/utils.js b/src/voice/utils.js
@@ -5,19 +5,27 @@ const require = createRequire(import.meta.url)
 let lame = null
 if (!process.isBun) lame = require('@flat/lame') /* libmp3lame bindings */
 
-import SampleRate from 'node-libsamplerate' /* libsamplerate bindings */
-
 import config from '../../config.js'
 import constants from '../../constants.js'
 
+let SampleRate = null
 let resamplingQuality = null
-switch (config.audio.resamplingQuality) {
-  case 'best': resamplingQuality = SampleRate.SRC_SINC_BEST_QUALITY; break
-  case 'medium': resamplingQuality = SampleRate.SRC_SINC_MEDIUM_QUALITY; break
-  case 'fastest': resamplingQuality = SampleRate.SRC_ZERO_ORDER_HOLD; break
-  case 'zero order holder': resamplingQuality = SampleRate.SRC_ZERO_ORDER_HOLD; break
-  case 'linear': resamplingQuality = SampleRate.SRC_LINEAR; break
+
+async function _startUp() {
+  if (config.options.nativePlayback) {
+    SampleRate = await import('node-libsamplerate')
+    SampleRate = SampleRate.default
+
+    switch (config.audio.resamplingQuality) {
+      case 'best': resamplingQuality = SampleRate.SRC_SINC_BEST_QUALITY; break
+      case 'medium': resamplingQuality = SampleRate.SRC_SINC_MEDIUM_QUALITY; break
+      case 'fastest': resamplingQuality = SampleRate.SRC_ZERO_ORDER_HOLD; break
+      case 'zero order holder': resamplingQuality = SampleRate.SRC_ZERO_ORDER_HOLD; break
+      case 'linear': resamplingQuality = SampleRate.SRC_LINEAR; break
+    }
+  }
 }
+_startUp()
 
 class NodeLinkStream {
   constructor(stream, pipes, ffmpegState) {
@@ -111,7 +119,7 @@ function isDecodedInternally(stream, type) {
     case 'webm/opus':
     case 'ogg/opus': return 3 + 1 + (stream.ffmpegState === 2 ? -2 : 0)
     case 'wav': return 2 + 1 + (stream.ffmpegState === 2 ? -2 : 0)
-    case 'mp3': return lame ? 2 + 1 + (stream.ffmpegState === 2 ? -2 : 0) : false
+    case 'mp3': return lame && SampleRate ? 2 + 1 + (stream.ffmpegState === 2 ? -2 : 0) : false
     default: return false
   }
 }
@@ -143,7 +151,7 @@ function createAudioResource(stream, type, additionalPipes = [], ffmpegState = f
     ], ffmpegState)
   }
 
-  if (type === 'mp3' && lame) {
+  if (type === 'mp3' && lame && SampleRate) {
     return new NodeLinkStream(stream, [
       new lame.Decoder(),
       new SampleRate.SampleRate({