Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switching to Android client, correcting problems with using IOS #95

Merged
merged 3 commits into from
Jan 28, 2025

Conversation

1Lucas1apk
Copy link
Contributor

Changes

changing the default client for fetching streams, among others, from IOS to Android, and correcting the problem saying that the client version was out of date, adding some parameters.

When using postman, I noticed that the header requires the User-Agent as in the client, and some parts were missing, so I added those parts that were missing, and also added androidSdkVersion, which without it causes the problem to return.

and after that, I placed the parts where he used IOS for ANDROID, and kept the IOS information in case in the future I wanted to make a user scheme change the client for specific functions.

I tested video, playlist, short, live, everything is working as expected.

Why

fix problems with the IOS client and have less headaches

Checkmarks

  • The modified endpoints have been tested.
  • Used the same indentation as the rest of the project.
  • Still compatible with LavaLink clients.

Additional information

No.

Copy link
Member

@ThePedroo ThePedroo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if tested overall

src/sources/youtube.js Outdated Show resolved Hide resolved
src/sources/youtube.js Outdated Show resolved Hide resolved
@1Lucas1apk 1Lucas1apk requested a review from ThePedroo January 23, 2025 19:09
@1Lucas1apk
Copy link
Contributor Author

Ready

Signed-off-by: Lucas Morais Rodrigues <[email protected]>
src/sources/youtube.js Outdated Show resolved Hide resolved
Copy link
Contributor

@RainyXeon RainyXeon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same like pedro and you're good to go!

@UnschooledGamer
Copy link
Collaborator

@ThePedroo comma in the end have been removed. You may merge this PR. Or request if any changes are needed.

@ThePedroo ThePedroo merged commit fae1694 into PerformanC:main Jan 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants