Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set default ENTRYPOINT #69

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zakame
Copy link
Member

@zakame zakame commented Aug 5, 2019

This installs and sets tini as the default ENTRYPOINT for Perl images, to enable Perl programs in containers to handle signals correctly, particularly on SIGINT/SIGTERM.

Ref. #44

@mohawk2
Copy link

mohawk2 commented Sep 14, 2020

Bump? (also there are conflicts that would need some TLC)

@zakame
Copy link
Member Author

zakame commented Sep 14, 2020

Yes, the conflicts are from the lone commit regenerating Dockerfiles, which can be dropped.

I think we just need to check on whether users are (usually) customizing ENTRYPOINT (or not,) and documenting for least astonishment.

@mohawk2
Copy link

mohawk2 commented Sep 15, 2020

Hmm. Search all of GitHub's Perl repos for such usage? I guess docs would be needed in any case. I seriously doubt anyone is relying on the current behaviour of not doing signals right? ;-)

@sdt
Copy link

sdt commented Sep 15, 2020

Is this now covered by the --init flag to docker run ?

@zakame
Copy link
Member Author

zakame commented Sep 15, 2020

@sdt yes, though as #44 (comment) notes we can't rely on --init for running outside of Docker, such as in k8s.

@mohawk2 right, we've had a doc for this since docker-library/docs#1550, which could do with an update (e.g. maybe mention https://github.com/openSUSE/catatonit as another alternative, or use sigtrap ... if handling from Perl natively.)

This allows Perl programs to run under tini and handle signals
correctly, particularly on SIGINT/SIGTERM.
@zakame zakame force-pushed the set-default-entrypoint branch from 1549aa8 to 7d99ed8 Compare September 15, 2020 04:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants