Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lint the uploaded zips #10

Open
PeterJCLaw opened this issue Jun 26, 2020 · 3 comments
Open

Lint the uploaded zips #10

PeterJCLaw opened this issue Jun 26, 2020 · 3 comments
Labels
enhancement New feature or request nice to have This would be nice to have, but is not essential

Comments

@PeterJCLaw
Copy link
Owner

Would be super-awesome to run linting against the uploaded archives, just like the IDE does.

@PeterJCLaw PeterJCLaw added enhancement New feature or request nice to have This would be nice to have, but is not essential labels Jun 26, 2020
@PeterJCLaw
Copy link
Owner Author

We've had a couple of teams who managed to submit broken code (including one which was a SyntaxError) for the first leagues, so it would be really great to have this.

@PeterJCLaw
Copy link
Owner Author

Extreme idea here: run a match of the robot against itself in CI and vend the recording back to the team for confirmation.

@PeterJCLaw
Copy link
Owner Author

A more minimal check we could use here would be to just validate that the code is valid Python, by compiling it to an AST. This is probably simpler to implement as we can do it all in memory and without an interesting dependencies. There's the small catch that the Python version the submitter runs as likely doesn't match the one used in the competition, but this would still catch a bunch of useful cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request nice to have This would be nice to have, but is not essential
Projects
None yet
Development

No branches or pull requests

1 participant