Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix x-axis labels overlapping #5243

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

yaugenka
Copy link

@yaugenka yaugenka commented Jan 15, 2022

Fixes #3298, Fixes #2980, Fixes #4640, Fixes #4557, Fixes #3673.

For those who are looking for a workaround solution, have posted one into #3298.

The fix required modification of AxisRender.ComputeAxisValues just for XAxis.
In order to avoid code duplication, the following refactoring was done.
ComputeAxisValues was split into CompleteAxisInterval (the part which differs for X and Y axis) and ComputeAxisValues (the common part). The resulting workflow is X/YAxisRenderer.ComputeAxis -> X/YAxisRenderer.CompleteAxisInterval -> AxisRender.ComputeAxisValues.

@yaugenka yaugenka changed the title Add spaceBetweenLabelsMin property to XAxis; fix xAsis labels overlapping Fix x-axis labels overlapping Jan 26, 2022
@hannesa2
Copy link
Contributor

hannesa2 commented Feb 25, 2022

Nice changes, what do you think about this ? #5268

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants