Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factory: initializes the multihop from the initialize method of factory and saves the multihop address in Config #158

Conversation

gangov
Copy link
Collaborator

@gangov gangov commented Oct 19, 2023

No description provided.

@gangov gangov requested a review from ueco-jb October 19, 2023 07:53
@gangov gangov marked this pull request as ready for review October 19, 2023 20:49
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

What's missing:

  • add multihop's build to factory's Makefile (just like you added to the pool stable)
  • add entry in the changelog

After that you can merge.

contracts/factory/src/tests/config.rs Show resolved Hide resolved
@gangov gangov merged commit 4d4df9d into main Oct 24, 2023
3 checks passed
@gangov gangov deleted the 152-factory-instantiate-multihop-contract-during-initialization-and-save-it-in-configuration branch October 24, 2023 05:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Factory: Instantiate multihop contract during initialization and save it in configuration
2 participants