156 multihop add transaction chain validation #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gangov
commented
Oct 24, 2023
|
do I need a different order for swap and reverse_swap, because now we have 3 failing tests? I don't think the reverse_swap logic was written with errors inside, so I'm wondering |
Have you checked how reverse swap tests were written? Do you understand its logic? |
ueco-jb
reviewed
Oct 25, 2023
ueco-jb
reviewed
Oct 26, 2023
Co-authored-by: Jakub Bogucki <[email protected]>
gangov
force-pushed
the
156-multihop-add-transaction-chain-validation
branch
from
42fb1e1 to
6abea8d
Compare
ueco-jb
reviewed
Oct 27, 2023
…dds two more tests for reverse_swap
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.