Stake: pay rewards during unbond #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ltihop: formatting
gangov
force-pushed
the
80-stake-pay-rewards-during-unbond
branch
from
56af681 to
aa5de26
Compare
ueco-jb
reviewed
Mar 6, 2024
ueco-jb
reviewed
Mar 6, 2024
|
Also you did nothing on multihop, so the title is misleading. |
gangov
changed the title
ueco-jb
reviewed
Mar 8, 2024
ueco-jb
reviewed
Mar 8, 2024
ueco-jb
reviewed
Mar 8, 2024
ueco-jb
reviewed
Mar 8, 2024
contracts/stake/src/tests/bond.rs
Outdated
Comment on lines
250
to
254
| staking.fund_distribution(&owner, &0u64, &10_000u64, &lp_token.address, &AMOUNT); | ||
|
|
||
| env.ledger().with_mut(|li| { | ||
| li.timestamp = WITHDRAW_TIMESTAMP; | ||
| }); |
There was a problem hiding this comment.
You created a distribution ranging from timestamp 0 to timestamp 10_000, and you immediately jump 2000 seconds ahead. Why?
There was a problem hiding this comment.
I chose numbers based on other places in our code where we change the ledger().timestamp. Do the numbers we use matter?
ueco-jb
approved these changes
Mar 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.