Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

All: add constructors #412

Merged
merged 15 commits into from
Jan 15, 2025
Merged

All: add constructors #412

merged 15 commits into from
Jan 15, 2025

Conversation

gangov
Copy link
Collaborator

@gangov gangov commented Jan 7, 2025

No description provided.

@gangov gangov self-assigned this Jan 7, 2025
@gangov gangov linked an issue Jan 7, 2025 that may be closed by this pull request
Comment on lines 453 to 459
if is_initialized(&env) {
log!(
&env,
"Factory: Initialize: initializing contract twice is not allowed"
);
panic_with_error!(&env, ContractError::AlreadyInitialized);
}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Aren't these redundant now?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not 100% sure they are - during testing, we can still get to this error if we set the same address.

@gangov gangov changed the title Kalo/add constructors All: add constructors Jan 7, 2025
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ueco-jb ueco-jb merged commit d8a46ff into main Jan 15, 2025
3 checks passed
@ueco-jb ueco-jb deleted the kalo/add-constructors branch January 15, 2025 13:11
@gangov gangov restored the kalo/add-constructors branch January 15, 2025 19:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

all: add constructors
2 participants