Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stake: using tag v1.0.0 impl #429

Merged
merged 36 commits into from
Feb 21, 2025
Merged

Stake: using tag v1.0.0 impl #429

merged 36 commits into from
Feb 21, 2025

Conversation

gangov
Copy link
Collaborator

@gangov gangov commented Jan 27, 2025

this PR removes the stake-rewards contract and brings back the old stake contract implementation

@gangov gangov self-assigned this Jan 27, 2025
@gangov gangov linked an issue Jan 27, 2025 that may be closed by this pull request
@gangov gangov requested a review from ueco-jb January 27, 2025 12:45
@gangov gangov changed the title Stake: tag v1.0.0 impl Stake: using tag v1.0.0 impl Jan 27, 2025
@gangov
Copy link
Collaborator Author

gangov commented Jan 28, 2025

changed the math back to safe math not only the highlighted places, but in a bunch of others. What's cool is that we can also use checked math when doing << and >>

@gangov gangov force-pushed the kalo/original-rewards-impl branch from 9f3c8ad to b89193f Compare January 28, 2025 18:35
@gangov gangov requested a review from ueco-jb February 3, 2025 12:37
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@gangov gangov requested a review from ueco-jb February 4, 2025 16:51
@gangov gangov force-pushed the kalo/original-rewards-impl branch from 62c48bc to 43bfe3f Compare February 17, 2025 15:56
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@gangov gangov force-pushed the kalo/original-rewards-impl branch from 43bfe3f to 5b67e0d Compare February 21, 2025 16:51
@gangov gangov merged commit 9ce6b63 into main Feb 21, 2025
3 checks passed
@gangov gangov deleted the kalo/original-rewards-impl branch February 21, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stake: old implementation
2 participants