Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auction: implementation #13

Merged
merged 100 commits into from
Sep 12, 2024
Merged

Auction: implementation #13

merged 100 commits into from
Sep 12, 2024

Conversation

gangov
Copy link
Collaborator

@gangov gangov commented Aug 20, 2024

No description provided.

@gangov gangov self-assigned this Aug 20, 2024
@gangov gangov linked an issue Aug 20, 2024 that may be closed by this pull request
Auction: Implement the contract #9
Closed
@gangov gangov requested a review from ueco-jb August 30, 2024 12:16
ueco-jb
ueco-jb reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Initial review of the implementation alone.

contracts/auctions/src/contract.rs Outdated Show resolved Hide resolved
contracts/auctions/src/contract.rs Outdated Show resolved Hide resolved
contracts/auctions/src/contract.rs Outdated Show resolved Hide resolved
contracts/auctions/src/contract.rs Outdated Show resolved Hide resolved
contracts/auctions/src/contract.rs Outdated Show resolved Hide resolved
contracts/auctions/src/contract.rs Show resolved Hide resolved
contracts/auctions/src/contract.rs Outdated Show resolved Hide resolved
contracts/auctions/src/contract.rs Outdated Show resolved Hide resolved
contracts/auctions/src/contract.rs Show resolved Hide resolved
contracts/auctions/src/contract.rs Show resolved Hide resolved
ueco-jb
ueco-jb reviewed Aug 30, 2024
View reviewed changes
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments regarding the storage, I will review the tests after those are solved.

contracts/auctions/src/lib.rs Show resolved Hide resolved
contracts/auctions/src/storage.rs Show resolved Hide resolved
contracts/auctions/src/storage.rs Outdated Show resolved Hide resolved
contracts/auctions/src/storage.rs Outdated Show resolved Hide resolved
contracts/auctions/src/storage.rs Outdated Show resolved Hide resolved
contracts/token/Cargo.toml Outdated Show resolved Hide resolved
@gangov gangov force-pushed the 9-auction-implement-the-contract branch from b14bce6 to cff1d13 Compare September 4, 2024 10:13
gangov added 24 commits September 6, 2024 11:09
ueco-jb
ueco-jb reviewed Sep 10, 2024
View reviewed changes
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pushing the review

contracts/auctions/src/contract.rs Outdated Show resolved Hide resolved
contracts/auctions/src/contract.rs Outdated Show resolved Hide resolved
contracts/auctions/src/utils.rs Outdated Show resolved Hide resolved
contracts/auctions/src/utils.rs Outdated Show resolved Hide resolved
contracts/auctions/src/utils.rs Outdated Show resolved Hide resolved
contracts/auctions/src/storage.rs Outdated Show resolved Hide resolved
@gangov gangov requested a review from ueco-jb September 10, 2024 15:24
ueco-jb
ueco-jb reviewed Sep 11, 2024
View reviewed changes
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some more comments.

contracts/auctions/src/contract.rs Outdated Show resolved Hide resolved
contracts/auctions/src/utils.rs Outdated Show resolved Hide resolved
contracts/auctions/src/contract.rs Outdated Show resolved Hide resolved
contracts/auctions/src/contract.rs Show resolved Hide resolved
contracts/auctions/src/contract.rs Outdated Show resolved Hide resolved
contracts/auctions/src/contract.rs Outdated Show resolved Hide resolved
@gangov gangov requested a review from ueco-jb September 11, 2024 15:11
ueco-jb
ueco-jb approved these changes Sep 12, 2024
View reviewed changes
Copy link
Member

@ueco-jb ueco-jb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge it and do the comment in the follow up.

contracts/auctions/src/contract.rs Show resolved Hide resolved
@gangov gangov mentioned this pull request Sep 12, 2024
Closed
@gangov gangov merged commit 4fa8001 into master Sep 12, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ueco-jb ueco-jb ueco-jb approved these changes

Assignees

@gangov gangov

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auction: Implement the contract
2 participants
@gangov @ueco-jb