create deployer contract #7

gangov · 2024-08-14T09:08:09Z

No description provided.

contracts/collections/src/contract.rs

contracts/deployer/src/tests.rs

ueco-jb

burn and burn_batch has a wrong implementation, since you only call

//FIXME: who can burn? - admin/sender/both
from.require_auth();

while you should check if that's the owner or operator.

gangov · 2024-08-19T14:51:36Z

closing this, will utilize operator in a separate PR

gangov linked an issue Aug 14, 2024 that may be closed by this pull request

create Deployer contract #6

Closed

gangov requested a review from ueco-jb August 14, 2024 09:11

gangov self-assigned this Aug 14, 2024

ueco-jb reviewed Aug 15, 2024

View reviewed changes

contracts/collections/src/contract.rs Outdated Show resolved Hide resolved

contracts/deployer/src/tests.rs Outdated Show resolved Hide resolved

gangov requested a review from ueco-jb August 16, 2024 08:16

gangov force-pushed the 6-create-deployer-contract branch from aa096c5 to a5471e9 Compare August 16, 2024 11:08

ueco-jb reviewed Aug 19, 2024

View reviewed changes

ueco-jb mentioned this pull request Aug 19, 2024

Collections: changes after merge #8

Merged

gangov added 6 commits August 19, 2024 17:30

after merge conflict

f4bc354

couple more query fns

5615bdb

after rebase conflicts

3bd4360

adds a test where 2 users deploy 3 collections

f6f5cba

fixes the tests and Makefile

6dab2c2

adds README.md to deployer

ed7a2c3

gangov force-pushed the 6-create-deployer-contract branch from b4fb277 to ed7a2c3 Compare August 19, 2024 14:30

adds proper authentication to burn and batch_burn

4458459

gangov merged commit 69df66b into master Aug 19, 2024
3 checks passed

Provide feedback