Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't cancel in-progress on main #1711

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

Don't cancel in-progress on main #1711

wants to merge 1 commit into from

Conversation

mcm001
Copy link
Contributor

@mcm001 mcm001 commented Jan 12, 2025

No description provided.

@mcm001 mcm001 requested a review from a team as a code owner January 12, 2025 04:49
crschardt
crschardt approved these changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@crschardt crschardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mcm001
Copy link
Contributor Author

mcm001 commented Jan 12, 2025

Actually, is this behavior something we want? I can see an argument for not gumming up Actions when we merge a lot of stuff quickly.

@crschardt
Copy link
Contributor

Actually, is this behavior something we want? I can see an argument for not gumming up Actions when we merge a lot of stuff quickly.

I guess it depends on if there is any value for those Actions completing for every merge to main. If there is a workflow failure, after merging, would it help to see which merge caused the failure? If we cancel the Actions, then a string of merges might lead to a failed action but it wouldn't be clear which specific merge caused the problem.

@mcm001
Copy link
Contributor Author

mcm001 commented Jan 12, 2025

Yeah that's exactly what i was trying to get at. Peter mentioned that allwpilib had seen formatting failures sneak in, but nothing major/breaking. Generally I dont think we have a terribly long queue if we just wait a bit after merging a bunch.

Also need to update other build workflows.

@mcm001 mcm001 marked this pull request as draft January 12, 2025 05:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crschardt crschardt crschardt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mcm001 @crschardt