Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Image version variables #1712

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Image version variables #1712

wants to merge 5 commits into from

Conversation

Juniormunk
Copy link
Contributor

No description provided.

@Juniormunk Juniormunk requested a review from a team as a code owner January 12, 2025 05:22
@Juniormunk Juniormunk changed the title Image Version Variables Image version variables Jan 12, 2025
mcm001
mcm001 approved these changes Jan 12, 2025
View reviewed changes
Copy link
Contributor

@mcm001 mcm001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TY <3

@crschardt
Copy link
Contributor

I tried to do this in photon-image-modifier and couldn't find a way to use environment variables in this part of the workflow. If you come up with something, I'll do the same in photon-image-modifier.

mcm001
mcm001 reviewed Jan 12, 2025
View reviewed changes
.github/workflows/build.yml Outdated Show resolved Hide resolved
@mcm001
Copy link
Contributor

mcm001 commented Jan 12, 2025

Still failing as of latest commit:
bash ${GITHUB_ACTION_PATH}/download_image.sh https://github.com/PhotonVision/photon-image-modifier/releases/download//photonvision_raspi.img.xz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcm001 mcm001 mcm001 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Juniormunk @crschardt @mcm001