-
Notifications
You must be signed in to change notification settings - Fork 214
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yolo docs #1715
Draft
Sam948-byte
wants to merge
10
commits into
PhotonVision:main
Choose a base branch
from
Sam948-byte:yolo-docs
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Yolo docs #1715
Changes from 6 commits
Commits
Show all changes
10 commits
Select commit
Hold shift + click to select a range
ffe3fce
oh boy documentation!
Sam948-byte 43c0429
oh boy documentation!
Sam948-byte 2ab3317
Merge branch 'yolo-docs' of github.com:Sam948-byte/photonvision into …
Sam948-byte d39f992
update retribution to reflect a specific commit
Sam948-byte 8a0e501
Merge branch 'main' into yolo-docs
Sam948-byte 54778b4
Fun Fact!
Sam948-byte 9b8af16
oooh scary warning
Sam948-byte 09cbf2c
fix warning
Sam948-byte 8c6431b
Merge branch 'main' into yolo-docs
Sam948-byte ce6e2ae
Merge branch 'main' into yolo-docs
Sam948-byte File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Per discord - this should be permalinked - IE, the link contains the sha1 of the commit referenced.
https://github.com/PhotonVision/photonvision/blob/54778b4e1c6ae0f6ccd3d663384ca250b0b119a5/scripts/yolov8_to_rknn.ipynb is one way of doing it, though that links to a PR of the file.
I don't actually know if/how to permalink before the PR is approved, I'd ask for a quick investigation to see if we can hit this in one shot. If not, it's a followup after the new file is merged to main.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
permalink I think it has to be committed first