Update Allowed Naming Conventions For Object Detection Models #1749
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
@mcm001 I think I added the check correctly, but I'm not sure if I need to call it somewhere else as well, or just put it in the tests folder. |
|
They should be picked up automatically by junit, yep. How might you tell if they are or arent? |
mcm001
reviewed
Jan 27, 2025
photon-core/src/main/java/org/photonvision/common/configuration/NeuralNetworkModelManager.java
Outdated
Show resolved
Hide resolved
mcm001
reviewed
Jan 27, 2025
photon-core/src/test/java/org/photonvision/vision/pipeline/ObjectDetectionTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Matt Morley <[email protected]>
mcm001
reviewed
Jan 28, 2025
photon-core/src/main/java/org/photonvision/common/configuration/NeuralNetworkModelManager.java
Outdated
Show resolved
Hide resolved
photon-core/src/main/java/org/photonvision/common/configuration/NeuralNetworkModelManager.java
Outdated
Show resolved
Hide resolved
photon-core/src/test/java/org/photonvision/vision/pipeline/ObjectDetectionTest.java
Outdated
Show resolved
Hide resolved
mcm001
reviewed
Feb 9, 2025
photon-core/src/test/java/org/photonvision/vision/pipeline/ObjectDetectionTest.java
Show resolved
Hide resolved
photon-core/src/test/java/org/photonvision/vision/pipeline/ObjectDetectionTest.java
Show resolved
Hide resolved
Sam948-byte
force-pushed
the
regexxxxx
branch
from
5f18071 to
5675369
Compare
mcm001
approved these changes
Feb 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add periods and underscores to the regex, add tests for the regex, and update documentation to reflect said change. Additionally migrate regex to NeuralNetworkManager, and use regex for parsing model values in RknnModel.java. closes #1747 There's also a typo that I'm tagging onto this PR as it's tangentially related.