Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Configure project setup #2

Merged
merged 12 commits into from
Feb 29, 2024
Merged

Configure project setup #2

merged 12 commits into from
Feb 29, 2024

Conversation

druzhinin-kirill
Copy link
Contributor

@druzhinin-kirill druzhinin-kirill commented Feb 22, 2024 •
edited
Loading

Configure project setup:

  • Add project's metadata
  • Set dev dependencies
  • Configure linters, pre-commit, tests, ci workflow

Todo

  • Align on supported Python version range
  • Update classifiers

@druzhinin-kirill druzhinin-kirill force-pushed the kdruzhinin/project-structure branch from 7fbc92e to 3713325 Compare February 22, 2024 16:58
@druzhinin-kirill druzhinin-kirill changed the title Kdruzhinin/project structure Configure project setup Feb 26, 2024
@druzhinin-kirill druzhinin-kirill marked this pull request as ready for review February 26, 2024 12:39
matthieucan
matthieucan reviewed Feb 26, 2024
View reviewed changes
Copy link
Contributor

@matthieucan matthieucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Could you add some instructions in the README, perhaps in a Development section? It can be as simple as "install pdm, run pdm install -d, run pdm run ruff check, pdm run pytest"

.github/workflows/ci.yml Outdated Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
@druzhinin-kirill druzhinin-kirill self-assigned this Feb 28, 2024
matthieucan
matthieucan reviewed Feb 28, 2024
View reviewed changes
tox.ini Show resolved Hide resolved
jochemvandooren
jochemvandooren reviewed Feb 28, 2024
View reviewed changes
Copy link
Contributor

@jochemvandooren jochemvandooren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks super nice 🤩 ! I am not very familiar with most of the tools, but I have run everything locally and everything just works very smoothly!

Just left a question and a small remark

.github/workflows/ci.yml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
matthieucan
matthieucan approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@matthieucan matthieucan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

jochemvandooren
jochemvandooren approved these changes Feb 29, 2024
View reviewed changes
Copy link
Contributor

@jochemvandooren jochemvandooren left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All works super nice on my WIP of dbt-score! 🚀

@druzhinin-kirill druzhinin-kirill merged commit cba523e into master Feb 29, 2024
2 checks passed
@matthieucan matthieucan deleted the kdruzhinin/project-structure branch March 13, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jochemvandooren jochemvandooren jochemvandooren approved these changes

@matthieucan matthieucan matthieucan approved these changes

Assignees

@druzhinin-kirill druzhinin-kirill

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@druzhinin-kirill @matthieucan @jochemvandooren