Lint the current dbt project only #53
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jochemvandooren
commented
Jun 12, 2024
| @@ -54,7 +54,7 @@ def cli() -> None: | |||
| @click.option( | |||
| "--namespace", | |||
| "-n", | |||
| help="Namespace.", | |||
| help="Namespace to look for rules.", | |||
There was a problem hiding this comment.
A small 'while there'
There was a problem hiding this comment.
(Not for this PR, but) I think we can make it clearer or more user-friendly. What about renaming it to --rules-directory and describe it as "The directory that stores your custom rules."
druzhinin-kirill
approved these changes
Jun 13, 2024
michael-the1
approved these changes
Jun 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of linting all models that can be found in the manifest, just lint the models from the current project.
Linting models of packages should be done in the dbt projects of the packages itself.