-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixes for phpBB 3.2 Rhea #40
Open
jbreu
wants to merge
47
commits into
Pico:master
Choose a base branch
from
jbreu:rhea_fixes
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+2,324
−294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FRENCH translation for exceptions.php file FRENCH translation for info_acp_reputation.php FRENCH translation for permissions_reputation.php FRENCH translation for reputation_acp.php FRENCH translation for reputation_common.php FRENCH translation for reputation_rating.php FRENCH translation for reputation_system.php FRENCH translation for reputation_toplist.php FRENCH translation for reputation_warning.php
FRENCH translation for info_acp_reputation.php file
FRENCH translation for permissions_reputation.php file
FRENCH translation for reputation_acp.php file
FRENCH translation for reputation_common.php file
FRENCH translation for reputation_rating.php file
FRENCH translation for reputation_system.php file
FRENCH translation for reputation_toplist.php file
FRENCH translation for reputation_warning.php file
Update for FRENCH translation for info_acp_reputation.php file
Update for ENGLISH translation for info_acp_reputation.php file
Update for FRENCH translation for reputation_acp.php file
Update for ENGLISH translation for reputation_system.php file Source: https://www.phpbb.com/community/viewtopic.php?p=13706431#p13706431
Update for FRENCH translation for reputation_system.php file Source: https://www.phpbb.com/community/viewtopic.php?f=456&t=2210021&start=45#p13706431
Minor update for ENGLISH for reputation_acp.php file
Update for reputation_common.php file : Change a language key which already exists (duplicate) in reputation_system.php
Update for reputation_common.php file which already exists (duplicate) in reputation_system.php
Correct update for reputation_common.php file in relation with: https://www.phpbb.com/community/viewtopic.php?f=456&t=2210021&start=120#p13851641
Correct update for reputation_system.php file in relation with: https://www.phpbb.com/community/viewtopic.php?f=456&t=2210021&start=120#p13851641
Correct update for reputation_common.php file in relation with: https://www.phpbb.com/community/viewtopic.php?f=456&t=2210021&start=120#p13851641
…yml according to symfony update
Fixes in notifications system
Ok, thanks for intagrated the PR38, i will submit you the PR 37 inside your fork. ;) |
Sorry, I am new to this stuff 😉 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Pico,
WorkingWarrior and me made necessary changes to your extension in order to make it ready for phpBB 3.2; it is not compatible to any earlier phpBB version < 3.2 as this is not possible.
The only thing I could not yet fix is the aggregation of notifications for the same post and user (function find_users_for_notification). Maybe this can be done by somebody else.
Best regards