Several fixes

README.md

@@ -1,7 +1,7 @@
 phpBB-Reputation-System
 =======================
 
-A full reputation (karma) system for phpBB3.1, with adjustable reputation settings.
+A full reputation (karma) system for phpBB3.3, with adjustable reputation settings.
 
 ## Features
 * AJAX post rating
@@ -12,7 +12,7 @@ A full reputation (karma) system for phpBB3.1, with adjustable reputation settin
 * and more
 
 ## Quick Install
-You can install this on the latest copy of the develop branch ([phpBB 3.1-dev](https://github.com/phpbb/phpbb3)) by following the steps below:
+You can install this on the latest copy of phpBB ([phpBB 3.3](https://github.com/phpbb/phpbb3)) by following the steps below:
 
 1. Download the latest repository.
 2. Unzip the downloaded release, and change the name of the folder to `reputation`.
@@ -38,7 +38,6 @@ You can install this on the latest copy of the develop branch ([phpBB 3.1-dev](h
 - [x] Notifications
 - [ ] Responsive design
 - [ ] Reputation ranks
-- [x] Updater from version for phpBB 3.0.x to release for phpBB 3.1.x - in progress (testing phase)
 
 ## License
 [GNU General Public License v2](http://opensource.org/licenses/GPL-2.0)

composer.json

@@ -3,7 +3,7 @@
 	"type": "phpbb-extension",
 	"description": "An extension which adds reputations (karma) to your board.",
 	"homepage": "https://github.com/Pico88/phpBB-Reputation-System",
-	"version": "1.0.0-dev",
+	"version": "1.1.0-dev",
 	"license": "GPL-2.0",
 	"authors": [
 		{
@@ -13,12 +13,12 @@
 		}
 	],
 	"require": {
-		"php": ">=5.3.3"
+		"php": ">=7.0"
 	},
 	"extra": {
 		"display-name": "Reputation System",
 		"soft-require": {
-			"phpbb/phpbb": ">=3.1.0-RC2,<3.2.*@dev"
+			"phpbb/phpbb": ">=3.3.0"
 		}
 	}
 }

config/listeners.yml

@@ -2,61 +2,61 @@ services:
     pico.reputation.acp_listener:
         class: pico\reputation\event\acp_listener
         arguments:
-            - @request
-            - @template
+            - '@request'
+            - '@template'
         tags:
             - { name: event.listener }
 
     pico.reputation.index_listener:
         class: pico\reputation\event\index_listener
         arguments:
-            - @auth
-            - @config
-            - @dbal.conn
-            - @controller.helper  
-            - @template
-            - @user
+            - '@auth'
+            - '@config'
+            - '@dbal.conn'
+            - '@controller.helper'
+            - '@template'
+            - '@user'
         tags:
             - { name: event.listener }
 
     pico.reputation.main_listener:
         class: pico\reputation\event\main_listener
         arguments:
-            - @config
-            - @template
+            - '@config'
+            - '@template'
         tags:
             - { name: event.listener }
 
     pico.reputation.mcp_listener:
         class: pico\reputation\event\mcp_listener
         arguments:
-            - @auth
-            - @config
-            - @request
-            - @template
-            - @user
-            - @pico.reputation.manager
+            - '@auth'
+            - '@config'
+            - '@request'
+            - '@template'
+            - '@user'
+            - '@pico.reputation.manager'
         tags:
             - { name: event.listener }
 
     pico.reputation.memberlist_listener:
         class: pico\reputation\event\memberlist_listener
         arguments:
-            - @auth
-            - @config
-            - @controller.helper 
+            - '@auth'
+            - '@config'
+            - '@controller.helper'
         tags:
             - { name: event.listener }
 
     pico.reputation.viewtopic_listener:
         class: pico\reputation\event\viewtopic_listener
         arguments:
-            - @auth
-            - @config
-            - @controller.helper
-            - @template
-            - @user
-            - @pico.reputation.helper
-            - %tables.reputations%
+            - '@auth'
+            - '@config'
+            - '@controller.helper'
+            - '@template'
+            - '@user'
+            - '@pico.reputation.helper'
+            - '%tables.reputations%'
         tags:
-            - { name: event.listener }
+            - { name: event.listener }

config/notifications.yml

@@ -1,55 +1,45 @@
 services:
     pico.reputation.notification.type.rate_post_positive:
         class: pico\reputation\notification\type\rate_post_positive
-        scope: prototype # scope MUST be prototype for this to work!
+        shared: false
+        parent: notification.type.base
         arguments:
-            - @user_loader
-            - @dbal.conn
-            - @cache.driver
-            - @user
-            - @auth
-            - @config
-            - %core.root_path%
-            - %core.php_ext%
-            - %tables.notification_types%
-            - %tables.notifications%
-            - %tables.user_notifications%
+            - '@cache.driver'
+            - '@config'
+            - '%tables.notification_types%'
+            - '%tables.notifications%'
+        calls:
+            - [set_controller_helper, ['@controller.helper']]
+            - [set_user_loader, ['@user_loader']]
         tags:
             - { name: notification.type }
 
     pico.reputation.notification.type.rate_post_negative:
         class: pico\reputation\notification\type\rate_post_negative
-        scope: prototype # scope MUST be prototype for this to work!
+        shared: false
+        parent: notification.type.base
         arguments:
-            - @user_loader
-            - @dbal.conn
-            - @cache.driver
-            - @user
-            - @auth
-            - @config
-            - %core.root_path%
-            - %core.php_ext%
-            - %tables.notification_types%
-            - %tables.notifications%
-            - %tables.user_notifications%
+            - '@cache.driver'
+            - '@config'
+            - '%tables.notification_types%'
+            - '%tables.notifications%'
+        calls:
+            - [set_controller_helper, ['@controller.helper']]
+            - [set_user_loader, ['@user_loader']]
         tags:
             - { name: notification.type }
 
     pico.reputation.notification.type.rate_user:
         class: pico\reputation\notification\type\rate_user
-        scope: prototype # scope MUST be prototype for this to work!
+        shared: false
+        parent: notification.type.base
         arguments:
-            - @user_loader
-            - @dbal.conn
-            - @cache.driver
-            - @user
-            - @auth
-            - @config
-            - @controller.helper
-            - %core.root_path%
-            - %core.php_ext%
-            - %tables.notification_types%
-            - %tables.notifications%
-            - %tables.user_notifications%
+            - '@cache.driver'
+            - '@config'
+            - '%tables.notification_types%'
+            - '%tables.notifications%'
+        calls:
+            - [set_controller_helper, ['@controller.helper']]
+            - [set_user_loader, ['@user_loader']]
         tags:
-            - { name: notification.type }
+            - { name: notification.type }

config/routing.yml

@@ -1,54 +1,69 @@
 reputation_clear_post_controller:
-    pattern: /reputation/clear/post/{post_id}
-    defaults: { _controller: pico.reputation.action.controller:clear_post }
+    path: /reputation/clear/post/{post_id}
+    defaults:
+        _controller: pico.reputation.action.controller:clear_post
     requirements:
         post_id: \d+
 
 reputation_clear_user_controller:
-    pattern: /reputation/clear/user/{uid}
-    defaults: { _controller: pico.reputation.action.controller:clear_user }
+    path: /reputation/clear/user/{uid}
+    defaults:
+        _controller: pico.reputation.action.controller:clear_user
     requirements:
         uid: \d+
 
 reputation_delete_controller:
-    pattern: /reputation/delete/{rid}
-    defaults: { _controller: pico.reputation.action.controller:delete }
+    path: /reputation/delete/{rid}
+    defaults:
+        _controller: pico.reputation.action.controller:delete
     requirements:
         rid: \d+
 
 reputation_details_controller:
-    pattern: /reputation/{uid}/{sort_key}/{sort_dir}/{page}
-    defaults: { _controller: pico.reputation.details.controller:details, sort_key: id, sort_dir: dsc, page: 1 }
+    path: /reputation/{uid}/{sort_key}/{sort_dir}/{page}
+    defaults:
+        _controller: pico.reputation.details.controller:details
+        sort_key: 'id'
+        sort_dir: 'dsc'
+        page: 1
     requirements:
         uid: \d+
-        sort_key: id|username|time|point|action
-        sort_dir: asc|dsc
+        sort_key: 'id|username|time|point|action'
+        sort_dir: 'asc|dsc'
 
 reputation_post_details_controller:
-    pattern: /reputation/details/post/{post_id}/{sort_key}/{sort_dir}
-    defaults: { _controller: pico.reputation.details.controller:postdetails, sort_key: id, sort_dir: dsc }
+    path: /reputation/details/post/{post_id}/{sort_key}/{sort_dir}
+    defaults:
+        _controller: pico.reputation.details.controller:postdetails
+        sort_key: 'id'
+        sort_dir: 'dsc'
     requirements:
         post_id: \d+
-        sort_key: id|username|time|point
-        sort_dir: asc|dsc
+        sort_key: 'id|username|time|point'
+        sort_dir: 'asc|dsc'
 
 reputation_post_rating_controller:
-    pattern: /reputation/rate/post/{mode}/{post_id}
-    defaults: { _controller: pico.reputation.rating.controller:post }
+    path: /reputation/rate/post/{mode}/{post_id}
+    defaults:
+        _controller: pico.reputation.rating.controller:post
     requirements:
-        mode: positive|negative
+        mode: 'positive|negative'
         post_id: \d+
 
 reputation_user_details_controller:
-    pattern: /reputation/details/user/{uid}/{sort_key}/{sort_dir}
-    defaults: { _controller: pico.reputation.details.controller:userdetails, sort_key: id, sort_dir: dsc }
+    path: /reputation/details/user/{uid}/{sort_key}/{sort_dir}
+    defaults:
+        _controller: pico.reputation.details.controller:userdetails
+        sort_key: 'id'
+        sort_dir: 'dsc'
     requirements:
         uid: \d+
-        sort_key: id|username|time|point|action
-        sort_dir: asc|dsc
+        sort_key: 'id|username|time|point|action'
+        sort_dir: 'asc|dsc'
 
 reputation_user_rating_controller:
-    pattern: /reputation/rate/user/{uid}
-    defaults: { _controller: pico.reputation.rating.controller:user }
+    path: /reputation/rate/user/{uid}
+    defaults:
+        _controller: pico.reputation.rating.controller:user
     requirements:
-        uid: \d+
+        uid: \d+