Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/Issue-199/fix-miss-config-route #203

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

lcaohoanq
Copy link

refactor: add type casting protect route, separate processing function

  • Separate to protect.schemas.ts
  • Change the old using require syntax to ES6 import .json file, after that changed , i need to re-define the interface Module accept nested Route inside
  • Change logic for checking the (role === undefined) instead of using (!role), this cause bug, always reach true
  • Change error message more clearly
    fix: fix protect route conflict with role
  • Admin can access all route
  • Customer only access /user
  • Employee only access /employee (not implement yet, so i deleted in my mapRouteWithRole.json, in the future any one who doing, please notice to add the route structure)

…n to each file

fix: fix protect route conflict with role
@lcaohoanq lcaohoanq merged commit 96cf914 into develop Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants