This repository has been archived by the owner on Nov 22, 2023. It is now read-only.
Fix/clang compiler errors #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There exists a compiler warning named "-Wgnu-zero-variadic-macro-arguments". If build with gcc this warning does not appear, however, build with clang the compiler warning appears. To avoid this problem a comma is added which resolves the problem.
leunMar
suggested changes
Nov 15, 2019
prbt_hardware_support/test/unittests/unittest_speed_observer.cpp
Outdated
Show resolved
Hide resolved
prbt_hardware_support/test/unittests/unittest_speed_observer.cpp
Outdated
Show resolved
Hide resolved
|
Please unify size_t usiage here, too: |
Done. |
|
@leunMar What do you think? Can we merge? |
leunMar
approved these changes
Nov 19, 2019
jschleicher
pushed a commit
that referenced
this pull request
Mar 12, 2020
* Fix clang compiler missing override warning in pilz_joint_trajectory_controller * Fix comma problem with INSTANTIATE_TEST_CASE_P There exists a compiler warning named "-Wgnu-zero-variadic-macro-arguments". If build with gcc this warning does not appear, however, build with clang the compiler warning appears. To avoid this problem a comma is added which resolves the problem. * Fix implicit conversion errors
jschleicher
added a commit
that referenced
this pull request
Mar 12, 2020
Errors << prbt_hardware_support: /root/target_ws/src/pilz_robots/prbt_hardware_support/test/unittests/unittest_operation_mode_setup_executor.cpp:303:1: error: macro "INSTANTIATE_TEST_CASE_P" passed 4 arguments, but takes just 3
martiniil
pushed a commit
that referenced
this pull request
Mar 24, 2020
* Fix clang compiler missing override warning in pilz_joint_trajectory_controller * Fix comma problem with INSTANTIATE_TEST_CASE_P There exists a compiler warning named "-Wgnu-zero-variadic-macro-arguments". If build with gcc this warning does not appear, however, build with clang the compiler warning appears. To avoid this problem a comma is added which resolves the problem. * Fix implicit conversion errors
martiniil
pushed a commit
that referenced
this pull request
Mar 24, 2020
Errors << prbt_hardware_support: /root/target_ws/src/pilz_robots/prbt_hardware_support/test/unittests/unittest_operation_mode_setup_executor.cpp:303:1: error: macro "INSTANTIATE_TEST_CASE_P" passed 4 arguments, but takes just 3
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix clang compiler errors.