Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "feat(br): enable condition trigger of br test on 8.1" #3367

Merged

Conversation

purelind
Copy link
Collaborator

@purelind purelind commented Feb 5, 2025

Reverts #3332

Some br tests have failed; automatic triggering will be enabled after the tests are fixed.

test link:

  1. https://do.pingcap.net/jenkins/blue/organizations/jenkins/pingcap%2Ftidb%2Frelease-8.1%2Fpull_br_integration_test/detail/pull_br_integration_test/29/pipeline/241
image

Copy link

ti-chi-bot bot commented Feb 5, 2025

I have already done a preliminary review for you, and I hope to help you do a better job.

Based on the pull request title and description, it seems that the changes made in the previous pull request have caused some test failures. Therefore, this pull request reverts those changes and disables automatic triggering until the tests are fixed.

The diff shows that the changes made in the previous pull request are being reverted in the release-8.1-presubmits.yaml file. In this file, the run_if_changed field is being changed to always_run: false and optional: true. Additionally, the skip_report field is being set to false.

As a reviewer, I would suggest checking the test failures that caused the revert and ensuring that all tests are passing before enabling automatic triggering again. Additionally, it may be helpful to provide more information on the specific test failures and what steps are being taken to fix them.

Regarding the changes in the diff, I would suggest double-checking with the developer why the optional: true field is being added. If it is necessary, then it should be documented clearly why it is being added. Otherwise, it may be better to remove it to avoid any confusion.

Overall, this pull request seems okay, but it would be helpful to have more context on the test failures and what steps are being taken to address them.

@ti-chi-bot ti-chi-bot bot requested a review from wuhuizuo February 5, 2025 10:23
@ti-chi-bot ti-chi-bot bot added the size/XS label Feb 5, 2025
@purelind
Copy link
Collaborator Author

purelind commented Feb 5, 2025

/cc @BornChanger

Copy link

ti-chi-bot bot commented Feb 5, 2025

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot merged commit 349a986 into main Feb 5, 2025
2 checks passed
@ti-chi-bot ti-chi-bot bot deleted the revert-3332-purelind/enable-trigger-of-br-test-on-8.1 branch February 5, 2025 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant