-
Notifications
You must be signed in to change notification settings - Fork 2
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request #120 from PinguApps/86-update-mfa
Implemented update mfa
- Loading branch information
Showing
9 changed files
with
188 additions
and
9 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
16 changes: 16 additions & 0 deletions
16
src/PinguApps.Appwrite.Shared/Requests/UpdateMfaRequest.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| using System.Text.Json.Serialization; | ||
| using PinguApps.Appwrite.Shared.Requests.Validators; | ||
|
|
||
| namespace PinguApps.Appwrite.Shared.Requests; | ||
|
|
||
| /// <summary> | ||
| /// The request for updating Mfa | ||
| /// </summary> | ||
| public class UpdateMfaRequest : BaseRequest<UpdateMfaRequest, UpdateMfaRequestValidator> | ||
| { | ||
| /// <summary> | ||
| /// Enable or disable MFA | ||
| /// </summary> | ||
| [JsonPropertyName("mfa")] | ||
| public bool MfaEnabled { get; set; } | ||
| } |
10 changes: 10 additions & 0 deletions
10
src/PinguApps.Appwrite.Shared/Requests/Validators/UpdateMfaRequestValidator.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| using FluentValidation; | ||
|
|
||
| namespace PinguApps.Appwrite.Shared.Requests.Validators; | ||
| public class UpdateMfaRequestValidator : AbstractValidator<UpdateMfaRequest> | ||
| { | ||
| public UpdateMfaRequestValidator() | ||
| { | ||
| RuleFor(x => x.MfaEnabled).NotNull(); | ||
| } | ||
| } |
80 changes: 80 additions & 0 deletions
80
tests/PinguApps.Appwrite.Client.Tests/Clients/Account/AccountClientTests.UpdateMfa.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,80 @@ | ||
| using System.Net; | ||
| using PinguApps.Appwrite.Shared.Requests; | ||
| using PinguApps.Appwrite.Shared.Tests; | ||
| using RichardSzalay.MockHttp; | ||
|
|
||
| namespace PinguApps.Appwrite.Client.Tests.Clients.Account; | ||
| public partial class AccountClientTests | ||
| { | ||
| [Fact] | ||
| public async Task UpdateMfa_ShouldReturnSuccess_WhenApiCallSucceeds() | ||
| { | ||
| // Arrange | ||
| var request = new UpdateMfaRequest() | ||
| { | ||
| MfaEnabled = true | ||
| }; | ||
|
|
||
| _mockHttp.Expect(HttpMethod.Patch, $"{Constants.Endpoint}/account/mfa") | ||
| .ExpectedHeaders(true) | ||
| .WithJsonContent(request) | ||
| .Respond(Constants.AppJson, Constants.UserResponse); | ||
|
|
||
| _appwriteClient.SetSession(Constants.Session); | ||
|
|
||
| // Act | ||
| var result = await _appwriteClient.Account.UpdateMfa(request); | ||
|
|
||
| // Assert | ||
| Assert.True(result.Success); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task UpdateMfa_ShouldHandleException_WhenApiCallFails() | ||
| { | ||
| // Arrange | ||
| var request = new UpdateMfaRequest() | ||
| { | ||
| MfaEnabled = true | ||
| }; | ||
|
|
||
| _mockHttp.Expect(HttpMethod.Patch, $"{Constants.Endpoint}/account/mfa") | ||
| .ExpectedHeaders(true) | ||
| .WithJsonContent(request) | ||
| .Respond(HttpStatusCode.BadRequest, Constants.AppJson, Constants.AppwriteError); | ||
|
|
||
| _appwriteClient.SetSession(Constants.Session); | ||
|
|
||
| // Act | ||
| var result = await _appwriteClient.Account.UpdateMfa(request); | ||
|
|
||
| // Assert | ||
| Assert.True(result.IsError); | ||
| Assert.True(result.IsAppwriteError); | ||
| } | ||
|
|
||
| [Fact] | ||
| public async Task UpdateMfa_ShouldReturnErrorResponse_WhenExceptionOccurs() | ||
| { | ||
| // Arrange | ||
| var request = new UpdateMfaRequest() | ||
| { | ||
| MfaEnabled = true | ||
| }; | ||
|
|
||
| _mockHttp.Expect(HttpMethod.Patch, $"{Constants.Endpoint}/account/mfa") | ||
| .ExpectedHeaders(true) | ||
| .WithJsonContent(request) | ||
| .Throw(new HttpRequestException("An error occurred")); | ||
|
|
||
| _appwriteClient.SetSession(Constants.Session); | ||
|
|
||
| // Act | ||
| var result = await _appwriteClient.Account.UpdateMfa(request); | ||
|
|
||
| // Assert | ||
| Assert.False(result.Success); | ||
| Assert.True(result.IsInternalError); | ||
| Assert.Equal("An error occurred", result.Result.AsT2.Message); | ||
| } | ||
| } |
46 changes: 46 additions & 0 deletions
46
tests/PinguApps.Appwrite.Shared.Tests/Requests/UpdateMfaRequestTests.cs
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| using PinguApps.Appwrite.Shared.Requests; | ||
|
|
||
| namespace PinguApps.Appwrite.Shared.Tests.Requests; | ||
| public class UpdateMfaRequestTests | ||
| { | ||
| [Fact] | ||
| public void Constructor_InitializesWithExpectedValues() | ||
| { | ||
| // Arrange & Act | ||
| var request = new UpdateMfaRequest(); | ||
|
|
||
| // Assert | ||
| Assert.False(request.MfaEnabled); | ||
| } | ||
|
|
||
| [Fact] | ||
| public void Properties_CanBeSet() | ||
| { | ||
| // Arrange | ||
| var request = new UpdateMfaRequest(); | ||
|
|
||
| // Act | ||
| request.MfaEnabled = true; | ||
|
|
||
| // Assert | ||
| Assert.True(request.MfaEnabled); | ||
| } | ||
|
|
||
| [Theory] | ||
| [InlineData(true)] | ||
| [InlineData(false)] | ||
| public void IsValid_WithValidData_ReturnsTrue(bool mfaEnabled) | ||
| { | ||
| // Arrange | ||
| var request = new UpdateMfaRequest | ||
| { | ||
| MfaEnabled = mfaEnabled | ||
| }; | ||
|
|
||
| // Act | ||
| var isValid = request.IsValid(); | ||
|
|
||
| // Assert | ||
| Assert.True(isValid); | ||
| } | ||
| } |