Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented delete authenticator #122

Merged
merged 8 commits into from
Aug 9, 2024
Merged

Implemented delete authenticator #122

merged 8 commits into from
Aug 9, 2024

Conversation

pingu2k4
Copy link
Contributor

@pingu2k4 pingu2k4 commented Aug 9, 2024

Changes

  • Implemented delete authenticator
  • Changed how we handle non body data to enable better error handling
  • Enabled responses with no return content

Issue

#89

Checklist before requesting a review

The PR will only be considered when all items within the checklist are marked as complete. Feel free to submit an incomplete draft PR, and add additional commits until you are able to satisfy each item within the checklist.

  • I have performed a self-review of my code
  • I have submitted at most one additional endpoint implementation
  • I have either submitted no additional endpoint implementation, or my implementation covers both client and server SDK's, unless either are marked in the README with a ❌
  • I have added applicable tests for my code
  • I have updated the README with updated status as a result of this PR

@pingu2k4 pingu2k4 self-assigned this Aug 9, 2024
@pingu2k4 pingu2k4 linked an issue Aug 9, 2024 that may be closed by this pull request
{
Result = result;
}

protected AppwriteResult()
{

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A closing brace should not be preceded by a blank line.

Suggested change

Copy link

github-actions bot commented Aug 9, 2024

Test Results

323 tests  +38   323 ✅ +38   5s ⏱️ -1s
  3 suites ± 0     0 💤 ± 0 
  3 files   ± 0     0 ❌ ± 0 

Results for commit 344d026. ± Comparison against base commit 78e0aaf.

This pull request removes 2 and adds 40 tests. Note that renamed tests count towards both.
PinguApps.Appwrite.Client.Tests.Utils.ResponseUtilsTests ‑ GetApiResponse_SuccessButNullContent_ReturnsInternalError
PinguApps.Appwrite.Server.Tests.Utils.ResponseUtilsTests ‑ GetApiResponse_SuccessButNullContent_ReturnsInternalError
PinguApps.Appwrite.Client.Tests.Clients.Account.AccountClientTests ‑ DeleteAuthenticator_ShouldHandleException_WhenApiCallFails
PinguApps.Appwrite.Client.Tests.Clients.Account.AccountClientTests ‑ DeleteAuthenticator_ShouldHitDifferentEndpoint_WhenNewTypeIsUsed
PinguApps.Appwrite.Client.Tests.Clients.Account.AccountClientTests ‑ DeleteAuthenticator_ShouldReturnErrorResponse_WhenExceptionOccurs
PinguApps.Appwrite.Client.Tests.Clients.Account.AccountClientTests ‑ DeleteAuthenticator_ShouldReturnSuccess_WhenApiCallSucceeds
PinguApps.Appwrite.Client.Tests.Utils.ResponseUtilsTests ‑ GenericGetApiResponse_FailureButNullErrorContent_ThrowsException
PinguApps.Appwrite.Client.Tests.Utils.ResponseUtilsTests ‑ GenericGetApiResponse_FailureButNullError_ThrowsException
PinguApps.Appwrite.Client.Tests.Utils.ResponseUtilsTests ‑ GenericGetApiResponse_Failure_ReturnsError
PinguApps.Appwrite.Client.Tests.Utils.ResponseUtilsTests ‑ GenericGetApiResponse_SuccessButNullContent_ReturnsInternalError
PinguApps.Appwrite.Client.Tests.Utils.ResponseUtilsTests ‑ GenericGetApiResponse_Success_ReturnsContent
PinguApps.Appwrite.Client.Tests.Utils.ResponseUtilsTests ‑ GenericGetExceptionResponse_ReturnsInternalError
…

♻️ This comment has been updated with latest results.

Copy link

github-actions bot commented Aug 9, 2024

Code Coverage

Package Line Rate Branch Rate Complexity Health
PinguApps.Appwrite.Client 100% 100% 80
PinguApps.Appwrite.Server 100% 100% 28
PinguApps.Appwrite.Shared 100% 100% 225
Summary 100% (530 / 530) 100% (88 / 88) 333

@pingu2k4 pingu2k4 merged commit df9813f into dev Aug 9, 2024
3 checks passed
@pingu2k4 pingu2k4 deleted the 89-delete-authenticator branch August 9, 2024 00:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Account - Delete Authenticator
1 participant