Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Made internal interfaces internal rather than public #70

Merged
merged 1 commit into from
Jul 13, 2024

Conversation

pingu2k4
Copy link
Contributor

Changes

Made internal interfaces internal rather than public

Issue

#65

Checklist before requesting a review

The PR will only be considered when all items within the checklist are marked as complete. Feel free to submit an incomplete draft PR, and add additional commits until you are able to satisfy each item within the checklist.

  • I have performed a self-review of my code
  • I have submitted at most one additional endpoint implementation
  • I have either submitted no additional endpoint implementation, or my implementation covers both client and server SDK's, unless either are marked in the README with a ❌
  • I have added applicable tests for my code
  • I have updated the README with updated status as a result of this PR

Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
PinguApps.Appwrite.Client 100% 93% 36
PinguApps.Appwrite.Server 100% 90% 18
PinguApps.Appwrite.Shared 100% 100% 76
Summary 100% (226 / 226) 94% (30 / 32) 130

Copy link

Test Results

125 tests  ±0   125 ✅ ±0   3s ⏱️ ±0s
  3 suites ±0     0 💤 ±0 
  3 files   ±0     0 ❌ ±0 

Results for commit 6ce025b. ± Comparison against base commit 46919e4.

@pingu2k4 pingu2k4 merged commit fff9ed9 into dev Jul 13, 2024
3 checks passed
@pingu2k4 pingu2k4 deleted the 65-internals-made-internal branch July 13, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Check if Internals can be made internal, and the library still safely used and consumed
1 participant