Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create session implementation #72

Merged
merged 16 commits into from
Jul 15, 2024
Merged

create session implementation #72

merged 16 commits into from
Jul 15, 2024

Conversation

pingu2k4
Copy link
Contributor

@pingu2k4 pingu2k4 commented Jul 15, 2024

Changes

create session implementation
Also fixes some session management issues

Issue

#42

Checklist before requesting a review

The PR will only be considered when all items within the checklist are marked as complete. Feel free to submit an incomplete draft PR, and add additional commits until you are able to satisfy each item within the checklist.

  • I have performed a self-review of my code
  • I have submitted at most one additional endpoint implementation
  • I have either submitted no additional endpoint implementation, or my implementation covers both client and server SDK's, unless either are marked in the README with a ❌
  • I have added applicable tests for my code
  • I have updated the README with updated status as a result of this PR

@pingu2k4 pingu2k4 self-assigned this Jul 15, 2024
@pingu2k4 pingu2k4 linked an issue Jul 15, 2024 that may be closed by this pull request
Copy link

github-actions bot commented Jul 15, 2024

Test Results

180 tests  +33   180 ✅ +33   4s ⏱️ -1s
  3 suites ± 0     0 💤 ± 0 
  3 files   ± 0     0 ❌ ± 0 

Results for commit be7db6b. ± Comparison against base commit 2575002.

This pull request removes 1 and adds 34 tests. Note that renamed tests count towards both.
PinguApps.Appwrite.Client.Tests.ServiceCollectionExtensionsTests ‑ AddAppwriteClientForServer_RegistersExpectedServicesWithTransientLifetime
PinguApps.Appwrite.Client.Tests.Clients.Account.AccountClientTests ‑ CreateSession_ShouldHandleException_WhenApiCallFails
PinguApps.Appwrite.Client.Tests.Clients.Account.AccountClientTests ‑ CreateSession_ShouldReturnErrorResponse_WhenExceptionOccurs
PinguApps.Appwrite.Client.Tests.Clients.Account.AccountClientTests ‑ CreateSession_ShouldReturnSuccess_WhenApiCallSucceeds
PinguApps.Appwrite.Client.Tests.Handlers.ClientCookieSessionHandlerTests ‑ SendAsync_InvalidBase64InASessionCookie_DoesNotSetSession
PinguApps.Appwrite.Client.Tests.Handlers.ClientCookieSessionHandlerTests ‑ SendAsync_InvalidJsonInDecodedBase64_DoesNotSetSession
PinguApps.Appwrite.Client.Tests.Handlers.ClientCookieSessionHandlerTests ‑ SendAsync_InvalidJsonInSessionCookie_DoesNotThrowJsonException
PinguApps.Appwrite.Client.Tests.Handlers.ClientCookieSessionHandlerTests ‑ SendAsync_NoASessionCookie_DoesNotSetSession
PinguApps.Appwrite.Client.Tests.Handlers.ClientCookieSessionHandlerTests ‑ SendAsync_NoSetCookieHeader_DoesNotSetSession
PinguApps.Appwrite.Client.Tests.Handlers.ClientCookieSessionHandlerTests ‑ SendAsync_SessionCookieMarkedAsDeleted_ClearsSession
PinguApps.Appwrite.Client.Tests.Handlers.ClientCookieSessionHandlerTests ‑ SendAsync_WhenResponseHasSessionCookie_SavesSessionCorrectly
…

♻️ This comment has been updated with latest results.

@pingu2k4
Copy link
Contributor Author

Need to fix code coverage...

…sionHandlerTests.cs

Co-authored-by: codefactor-io[bot] <47775046+codefactor-io[bot]@users.noreply.github.com>
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
PinguApps.Appwrite.Client 100% 97% 60
PinguApps.Appwrite.Server 100% 90% 19
PinguApps.Appwrite.Shared 100% 100% 128
Summary 100% (345 / 345) 97% (56 / 58) 207

@pingu2k4 pingu2k4 merged commit 7848520 into dev Jul 15, 2024
3 checks passed
@pingu2k4 pingu2k4 deleted the 42-create-session branch July 16, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEAT] Account - Create Session implementation
1 participant