Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed condition that we need to have a successful response to change cookies #74

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

pingu2k4
Copy link
Contributor

Changes

Removed condition that we need to have a successful response to change cookies

Issue

#73

Checklist before requesting a review

The PR will only be considered when all items within the checklist are marked as complete. Feel free to submit an incomplete draft PR, and add additional commits until you are able to satisfy each item within the checklist.

  • I have performed a self-review of my code
  • I have submitted at most one additional endpoint implementation
  • I have either submitted no additional endpoint implementation, or my implementation covers both client and server SDK's, unless either are marked in the README with a ❌
  • I have added applicable tests for my code
  • I have updated the README with updated status as a result of this PR

@pingu2k4 pingu2k4 self-assigned this Jul 16, 2024
Copy link

Code Coverage

Package Line Rate Branch Rate Complexity Health
PinguApps.Appwrite.Client 100% 97% 58
PinguApps.Appwrite.Server 100% 90% 19
PinguApps.Appwrite.Shared 100% 100% 128
Summary 100% (344 / 344) 96% (54 / 56) 205

Copy link

Test Results

180 tests  ±0   180 ✅ ±0   3s ⏱️ -1s
  3 suites ±0     0 💤 ±0 
  3 files   ±0     0 ❌ ±0 

Results for commit 693e601. ± Comparison against base commit 7848520.

@pingu2k4 pingu2k4 merged commit 490e315 into dev Jul 16, 2024
3 checks passed
@pingu2k4 pingu2k4 deleted the 73-session-handler-unsuccessful-responses branch July 16, 2024 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Client Cookie Session Handler should process unsuccessful responses
1 participant