Merge pull request #41 from PinguApps/40-bug-null-data-can-cause-a-crash

Added handling for null data
PinguApps · Feb 25, 2024 · a92a41a · a92a41a
2 parents 1109a2a + 9339546
commit a92a41a
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 1 deletion.
diff --git a/src/PinguApps.Blazor.QRCode/QRCode.razor b/src/PinguApps.Blazor.QRCode/QRCode.razor
@@ -91,7 +91,7 @@
 
     void GenerateQR()
     {
-        var qr = QrCode.EncodeText(Data, GetEcc);
+        var qr = QrCode.EncodeText(Data ?? "", GetEcc);
         var path = qr.ToGraphicsPath(PaddingCells);
         var viewboxSize = qr.Size + PaddingCells * 2;
 

diff --git a/tests/PinguApps.Blazor.QRCode.Tests/QRCodeTests.cs b/tests/PinguApps.Blazor.QRCode.Tests/QRCodeTests.cs
@@ -223,4 +223,20 @@ public async Task DataSnapshots(string data)
         settings.UseParameters(data);
         await Verify(component.Find("path").GetAttribute("d"), settings);
     }
+
+    [Fact]
+    public void AvoidsCrashWhenDataNull()
+    {
+        // Arrange
+        using var context = new TestContext();
+
+        // Act
+        var exception = Record.Exception(() =>
+        {
+            var component = context.RenderComponent<QRCode>(parameters => parameters.Add(p => p.Data, null));
+        });
+
+        // Assert
+        Assert.Null(exception);
+    }
 }