Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support OpenImageIO 3.x inside the hioOiio plugin #3365

Closed
wants to merge 1 commit into from

Conversation

jessey-git
Copy link

Description of Change(s)

The soon to be released OpenImageIO 3.x series drops a variety of old, deprecated, methods and types.

In the context of the imaging hioOiio plugin, this simply means to adjust the following [1]:

  • The ImageIOParameter type alias is removed and just ParamValue should be used
  • The read_image method must take in subimage, miplevel, and channel values explicitly

These changes are compatible with the OpenImageIO 2.x series and shouldn't present a problem for those not updating just yet.

[1] https://github.com/AcademySoftwareFoundation/OpenImageIO/blob/main/docs/Deprecations-3.0.md#imageioh

Fixes Issue(s)

  • Building against OIIO 3

  • I have verified that all unit tests pass with the proposed changes

  • I have submitted a signed Contributor License Agreement

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-10319

@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@jessey-git
Copy link
Author

Closing since PR #3418 was done in its place.

@jessey-git jessey-git closed this Jan 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants