Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodesk: Expose additional header files in pxr/imaging/hdSt in the USD package #3481

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

erikaharrison-adsk
Copy link
Contributor

Description of Change(s)

There are lots of files missing in the pxr/imaging/hdSt folder in the final package compared to the original source. Many of them are indispensable if we would like to use raw DrawItem. In additional, the classes in those missing files are all DLL exported. There are good reasons to expose them.  

  • shaderKey.h
  • drawBatch.h
  • pipelineDrawBatch.h
  • indirectDrawBatch.h
  • materialNetworkShader.h
  • resourceBinder.h

Also verified that making them public doesn't introduce symbol changes.

Link to proposal (if applicable)

  • N/A

Fixes Issue(s)

  • N/A

Checklist

@jesschimein
Copy link
Collaborator

Filed as internal issue #USD-10557

(This is an automated message. See here for more information.)

@jesschimein
Copy link
Collaborator

/AzurePipelines run

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants