Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new toast UI and operation hint message #82

Merged
merged 2 commits into from
Feb 12, 2023

Conversation

XuYicong
Copy link
Member

@XuYicong XuYicong commented Feb 8, 2023

Partly implemented #74

图片

图片

new_toast.mov

5 seconds after launch, if keymapping is not enabled, a message would appear prompting the user to enable keymapping. In this case, when the user enables keymapping, the previous message disappears and a message would appear prompting the user to disable keymapping. In this case, when the user disables keymapping, the message would disappear. Both messages show at most once during each launch.

Keymapping editor open and close messages are also migrated to the new UI. The open message would stay there until the user closes the editor. The close message would stay for 3 seconds.

@IsaacMarovitz
Copy link
Member

A couple of suggestions, capitalise Option, and secondly, set a max number of toasts. The video shows about ~10 onscreen at once, but we could probably limit this to like 4, i.e. quickly destroy any toasts at the end of the list if the limit is going to be exceeded. Either that or iOS notification style have them stack up if there's too many (might be kinda difficult tho don't wanna make ur life hard :kek:)

@FlyMeToTheMoonAndLetMePlayAmongTheStars
Copy link
Contributor

I think option is fine as it is, it's more consistent with the actual hardware key since that's not capitalized either. The color contrast already makes it more prominent/distinct.

@XuYicong
Copy link
Member Author

I agree that small option is more consistent with what is written on the hardware keyboard. And I limited number of toasts to 4.

limit4.mov

@Depal1 Depal1 merged commit 51ab649 into PlayCover:3.0.0-staging Feb 12, 2023
XuYicong pushed a commit to XuYicong/PlayTools that referenced this pull request Mar 4, 2023
Fixes SoundDeviceService, a deprecation, changes error alert title
IsaacMarovitz pushed a commit to IsaacMarovitz/PlayTools that referenced this pull request Mar 16, 2023
* add new hint toast

* limit toast number to four
IsaacMarovitz pushed a commit to IsaacMarovitz/PlayTools that referenced this pull request May 8, 2023
* add new hint toast

* limit toast number to four
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants