[IMPORT] feat: create and set import buttons #387
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jacquesfize
changed the title
jacquesfize
requested changes
Dec 18, 2024
| *ngIf="this.canImport" | ||
| color="primary" | ||
| class="btn-action uppercase float-right" | ||
| [routerLink]="['/import']" |
There was a problem hiding this comment.
il faut que la redirection dirige vers la page de création d'un import
Comment on lines
+75
to
+78
| const canCreateImport = cruvedImport.C > 0; | ||
| const canCreateMonitoring = this.userCruved.C > 0; | ||
|
|
||
| this.canImport = canCreateImport && canCreateMonitoring; |
There was a problem hiding this comment.
Suggested change
| const canCreateImport = cruvedImport.C > 0; | |
| const canCreateMonitoring = this.userCruved.C > 0; | |
| this.canImport = canCreateImport && canCreateMonitoring; | |
| this.canImport = cruvedImport.C > 0 && this.userCruved.C > 0; |
|
|
||
| // medias; | ||
| canCreateChild: { [key: string]: boolean } = {}; | ||
| toolTipNotAllowed: string = TOOLTIPMESSAGEALERT; | ||
|
|
||
| public userCruved: any; |
There was a problem hiding this comment.
Uniquement utilisée dans le ngOnInit... à supprimer pour moi
| // get user cruved | ||
| const currentModule = this._moduleService.currentModule; | ||
| this.userCruved = currentModule.module_objects.MONITORINGS_SITES.cruved; | ||
| let cruvedImport: any = {}; |
There was a problem hiding this comment.
Suggested change
| let cruvedImport: any = {}; | |
| let cruvedImport: any = {C:0}; |
|
|
||
| // get user cruved | ||
| const currentModule = this._moduleService.currentModule; | ||
| this.userCruved = currentModule.module_objects.MONITORINGS_SITES.cruved; |
There was a problem hiding this comment.
Pourquoi ne pas passer directement par le cruvedStore ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[IMPORT][MONITORING] IM_INIT_FROM_DEST_1 - Intégrer des boutons à l'interface de monitoring : https://github.com/orgs/PnX-SI/projects/13/views/6?pane=issue&itemId=83488034
A discuter :
est-ce utile de renvoyer id_base_site et id_dataset en queryParams pour le bouton situé dans la liste des observations (id_dataset peut être requêté directement à partir de l'id_base_visit, donc évite un check puisque si on l'envoie avec les queryParams il faudra vérifier de toute façon si l'id_dataset existe et est bien associé à la visite)