Revert pinned cmake version on Windows builds #416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AdamGlustein
requested review from
robambalu,
svatasoiu,
alexddobkin,
ptomecek and
timkpaine
as code owners
…e is failing to install properly on GH Actions (#415)" This reverts commit 1054f5c. Signed-off-by: Adam Glustein <[email protected]>
AdamGlustein
force-pushed
the
test-new-revert-windows-pin
branch
from
8f24b9a to
66abbff
Compare
timkpaine
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit 1054f5c.
I noticed
mainbuilds like this one were failing as of Friday with the following error message:I was going to add that flag but I first tried reverting the commit that pinned the cmake version, since we never knew why it was failing to install on GH Actions in the first place. Lo and behold the new cmake version (3.31.2) now seems to work on the GitHub builds, as this full CI run shows.