Add zlib dependency to conda dev environment and update websocket code for boost 1.87 #423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Adam Glustein <[email protected]>
AdamGlustein
requested review from
robambalu,
svatasoiu,
alexddobkin,
ptomecek and
timkpaine
as code owners
timkpaine
approved these changes
Jan 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds
zlibas a direct dependency of the conda environment file rather than having it pulled in transitively fromthrift, which is itself pulled in transitively fromarrow. GH Actions was finding a outdatedzlibversion (1.3) in the conda end-to-end test without having it directly listed in the environment, although I'm not sure why 🤷.Also, as we haven't run a conda build for about 3 weeks, boost upgraded from 1.86.0 to 1.87.0 in December which is causing a build failure in the websocket code. This is a one-line fix.