Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #425 #427

Merged
merged 3 commits into from
Jan 24, 2025
Merged

Fix #425 #427

merged 3 commits into from
Jan 24, 2025

Conversation

NeejWeej
Copy link
Collaborator

@NeejWeej NeejWeej commented Jan 13, 2025 •
edited
Loading

Fixes #425

@NeejWeej
Initial commit
3af6145 
Signed-off-by: Nijat Khanbabayev <[email protected]>
@NeejWeej NeejWeej force-pushed the nk/fix_425_38 branch 2 times, most recently from a311198 to 3e99632 Compare January 13, 2025 19:56
ptomecek
ptomecek requested changes Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@ptomecek ptomecek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As noted above, add CspTypeUtils.is_callable

csp/impl/types/instantiation_type_resolver.py Outdated Show resolved Hide resolved
csp/impl/types/typing_utils.py Show resolved Hide resolved
csp/impl/types/typing_utils.py Show resolved Hide resolved
@NeejWeej
Factor out callable check type checks
e48c2a7 
Signed-off-by: Nijat Khanbabayev <[email protected]>
@NeejWeej NeejWeej merged commit f376bd6 into main Jan 24, 2025
29 checks passed
@NeejWeej NeejWeej deleted the nk/fix_425_38 branch January 24, 2025 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AdamGlustein AdamGlustein AdamGlustein approved these changes

@ptomecek ptomecek ptomecek approved these changes

@robambalu robambalu Awaiting requested review from robambalu robambalu is a code owner

@svatasoiu svatasoiu Awaiting requested review from svatasoiu svatasoiu is a code owner

@alexddobkin alexddobkin Awaiting requested review from alexddobkin alexddobkin is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

version 0.0.6 improper type handling on Optional[List]
3 participants
@NeejWeej @ptomecek @AdamGlustein