Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add notice for licenses of dependencies #45

Merged
merged 1 commit into from
Feb 8, 2024
Merged

Add notice for licenses of dependencies #45

merged 1 commit into from
Feb 8, 2024

Conversation

timkpaine
Copy link
Member

No description provided.

@timkpaine timkpaine force-pushed the tkp/notice branch 2 times, most recently from 54a2ca4 to 3eaf526 Compare February 7, 2024 21:21
@timkpaine timkpaine added tag: internal Issues and PRs for maintainance of the project - not interesting to external users part: distribution Issues and PRs related to distribution, e.g. pypa and conda labels Feb 7, 2024
ngoldbaum
ngoldbaum reviewed Feb 8, 2024
View reviewed changes
Copy link
Contributor

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment. Also for static linking do we need to worry about licenses of dependencies pulled in by the direct dependencies listed in this file? I know the build pulls in boost, for example.

NOTICE Outdated Show resolved Hide resolved
@timkpaine
Copy link
Member Author

Just one comment. Also for static linking do we need to worry about licenses of dependencies pulled in by the direct dependencies listed in this file? I know the build pulls in boost, for example.

Yeah i tweaked how to generate so we can pull in everything, its a big file but seems fine

@timkpaine
Copy link
Member Author

also added a quick tweak for #48 while i was modifying the makefile

@timkpaine timkpaine requested review from ngoldbaum and removed request for AdamGlustein February 8, 2024 15:14
ngoldbaum
ngoldbaum approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@ngoldbaum ngoldbaum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me now, makes sense to automate this.

Makefile
@@ -114,7 +122,7 @@ major:
########
# DIST #
########
.PHONE: dist-py dist-py-sdist dist-py-wheel dist-py-cibw dist-check dist publish-py publish
.PHONY: dist-py dist-py-sdist dist-py-wheel dist-py-cibw dist-check dist publish-py publish
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oops, nice catch

@ngoldbaum ngoldbaum merged commit c011061 into main Feb 8, 2024
11 checks passed
@ngoldbaum ngoldbaum deleted the tkp/notice branch February 8, 2024 15:23
@ngoldbaum ngoldbaum mentioned this pull request Feb 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ngoldbaum ngoldbaum ngoldbaum approved these changes

Assignees
No one assigned
Labels
part: distribution Issues and PRs related to distribution, e.g. pypa and conda tag: internal Issues and PRs for maintainance of the project - not interesting to external users
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@timkpaine @ngoldbaum