Modify vcpkg caching, update runners to latest images, add macos M1 runner #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timkpaine
changed the title
timkpaine
force-pushed
the
tkp/cache
branch
28 times, most recently
from
6373797 to
14306d2
Compare
timkpaine
force-pushed
the
tkp/cache
branch
3 times, most recently
from
9afbc62 to
38a0f08
Compare
timkpaine
changed the title
ngoldbaum
reviewed
Feb 5, 2024
There was a problem hiding this comment.
In the output from the caching step I see output like: Cache not found for input keys: vcpkg-Linux-X64-7a0833a6925c4ade0c75ec84a7e2d2b43717272adddee7809c9cbf6878b86422, vcpkg-Linux-X64-. I don't immediately see what's wrong with the setup of the cache to trigger that though, or even if it's a problem.
Also one tiny nit in pyproject.toml, ignore if you disagree.
…dd mac arm runner Bump to ubuntu 22.04 and macOS-12 runners Add new macOS 14 M1 runner for arm wheels Signed-off-by: Tim Paine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes minor adjustments to the
vcpkgcaching. In particular, it seemsmacOSis ignoring the caching for itscibuildwheelsteps. This PR hopes to rectify that.Docs:
This PR also upgrades from
ubuntu-20.04andmacos-11runners toubuntu-22.04andmacos-12runners, the current aliases forubuntu-latestandmacos-latestrespectively.Finally, this PR adds the brand new
macos-14runners which run on M1 arm chips. This is critical because we currently require GNU toolchain, and the homebrew build cannot cross-compile, so we cannot e.g. build arm wheels from x86 chips. With the new M1 runners, we can build native arm wheels for mac.