Add python3.8 linux wheel builds #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this added an extra 170 MB of pip caches but other than that I don't see significant additional resource usage. I guess I could disable pip caching for python3.8 if we don't want to add the additional cache, it doesn't look like it took a lot of time to generate. |
timkpaine
previously approved these changes
Feb 13, 2024
ngoldbaum
dismissed
timkpaine’s stale review
The merge-base changed after approval.
Signed-off-by: Nathan Goldbaum <[email protected]>
ngoldbaum
force-pushed
the
python38-build
branch
from
dc50aa4 to
5625282
Compare
|
Looks like I rebased exactly when you approved and that invalidated the review, sorry about that! |
timkpaine
approved these changes
Feb 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doing this on top of #53 because of a fix in that PR. That should be merged first.
I got a request from @robambalu to add python3.8 linux wheels since there are some users who need that. There's a comment that we're not running these builds except on full runs to reduce CI usage. Opening this PR to see what the additional impact of these builds are now that we have caching fully working.