-
Notifications
You must be signed in to change notification settings - Fork 305
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ports extensions from Nebula #9059
base: master
Are you sure you want to change the base?
Ports extensions from Nebula #9059
Conversation
@@ -29,43 +29,53 @@ | |||
if(length(A.name) + length(label) > 64) | |||
to_chat(user, SPAN_WARNING("\The [src]'s label too big.")) | |||
return | |||
if(istype(A, /mob/living/silicon/robot/platform)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This block is separate to the label system generally, it renames the mob.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Disregard, just saw the proc.
I'm not sure if this is a good idea. Components and extensions have a ton of overlap in functionality even if the DSC pattern bars you from using components from extension-like functions. Having both systems in parallel feels like a complexity and maintenance issue. |
Snips unused code
I agree that the two-implementation solution is messy (See: nanoui v. tgui, among probably numerous other examples), but there actually isn't that much that uses components right now. |
I would want this to come with a commitment to transition existing component use to extensions, which I think defeats the "I much more often see shiny things that we could have" sentiment which, I assume, carries the caveat of still wanting the shiny things from components without the effort of translation. I agree with MistakeNot4892 - both is a recipe for overhead, interoperability issues, and dev headaches. I'm biased in favor of extensions because they're what I use already elsewhere. I've found DSC a tad less approachable, largely due to the rote use of its own signals system creating a lot of async funnies and signal comprehension instead of direct calls. Buuuut it is what currently exists. Translating extensions to it is just as possible. |
First pass at porting extensions, as on tin. Provided without verification but with warranty.