-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Redesign and rewrite mobile styling #899
Redesign and rewrite mobile styling #899
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to convert this to a draft PR so that it doesn't re-run actions every time I commit |
5a4cfe7
to
9a06bc4
Compare
ffda4bc
to
1a65f3f
Compare
4b69066
to
f344eb0
Compare
A Loom video of what these edits do in mobile is available at https://www.loom.com/share/4af0bc7cae8d435d9f51c0e0549c50a9?sid=c2b00346-ad40-4fab-8adc-bfff547b78bb. Please note that the reason there are two scroll boxes at some points in the video is that I selected a simulated mobile device longer than my desktop browser screen. |
@nikhilwoodruff was hoping you might be able to review this second round of edits. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Video looks great- thanks @anth-volk!
This commit reworks our current mobile styling templates so as to make the site more mobile-friendly. Fixes #844 and #877.
In my opinion, this should be pushed after #867. After #867, this PR will likely face merge conflict errors, at which point I would need to fix the buttons (as #867 changes the default button padding and renames/rewrites certain buttons). This PR is built with those changes in mind, which is why if you preview this commit off that branch, certain buttons are slightly off padding-wise.
🤖[deprecated] Generated by Copilot at 5a4cfe7
Summary
📱🔎♻️
This pull request improves the responsiveness, usability, and modularity of the policy engine app, especially for mobile devices. It refactors the policy and household calculator pages, extracts and adds props to some components, adjusts the styles and layouts of some components, and hides or deletes some redundant components. It also removes some whitespace in a markdown table in a blog post.
Walkthrough
moreOnClick
prop toNavigationButton
component to enable extra functionality on click (link, link)marginTop
style ofVariableEditor
component for mobile devices (link)BottomCarousel
component for mobile devices inHouseholdOutput
andPolicyOutput
components (link, link)useDisplayCategory
hook to get display category based on window width and adjustfontSize
andflexDirection
styles accordingly inNetIncomeBreakdown
andCalculatorInterstitial
components (link, link, link, link, link, link, link)PolicyRightSidebar
component fromflex
togrid
and remove or modifymargin
styles ofSearchOptions
andPolicySearch
components (link, link, link, link)ParameterSearch
component fromPolicyPage
tocontrols
folder and addcallback
prop (link, link)MobileHouseholdPage
component toMobileCalculatorPage
and move it tolayout
folder (link)MobileCalculatorPage
component for both household and policy calculators and passtype
prop (link, link, link)callback
prop toVariableSearch
component (link, link)Budgetary impacts
section inautumn-statement-2023
post (link)src/pages/household/MobileHouseholdPage.jsx
file (link)