Do not forget current household when clicking on policy display carousel #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikhilwoodruff
approved these changes
Dec 11, 2023
| @@ -117,7 +116,7 @@ export default function ParameterEditor(props) { | |||
| ); | |||
|
|
|||
| const timePeriodSentence = parameter.period | |||
| ? `This parameter is ${parameter.period}ly.` | |||
| ? ` This parameter is ${parameter.period}ly.` | |||
| newSearchParams, | ||
| )}`; | ||
| navigate(newUrl); | ||
| const newSearchParams = copySearchParams(searchParams); |
There was a problem hiding this comment.
Ah yep makes sense.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed #485.
According to the bug reproduction video, the household got lost after clicking on the current reform item in the policy's right sidebar. I fixed the issue by copying the existing search parameters for the new URL instead of creating the new URL from scratch.
On carrying out the policy edits suggested by the reproduction video, I noticed that the placeholder in the parameter editor did not reflect the last edit. This was due to a bug introduced in pull request #839 where I ignored the reform when creating the placeholder text. This bug is also fixed here.
Finally, I have also added a space before the 'This parameter is yearly.' sentence.
🤖[deprecated] Generated by Copilot at 3ba1cf0
Summary
🐛♻️📏
Fixed a bug and refactored some components in the policy input and display pages. Improved the input field value and rendering for
ParameterEditor.jsxand the URL state management forPolicyDisplayinPolicyRightSidebar.jsx.Walkthrough
PolicyDisplaycomponent inPolicyRightSidebar.jsx(link, link)ParameterEditor.jsx(link)