Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename interest_expense to deductible_interest_expense #5582

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

SonaliBedge
Copy link
Contributor

@SonaliBedge SonaliBedge commented Feb 12, 2025

fixed #5579 Renamed interest_expense to deductible_interest_expense

Copy link

codecov bot commented Feb 12, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.10%. Comparing base (75cc11e) to head (ba5992b).
Report is 45 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff            @@
##           master    #5582    +/-   ##
========================================
  Coverage   99.10%   99.10%            
========================================
  Files        2687     2697    +10     
  Lines       38934    39061   +127     
  Branches      170      172     +2     
========================================
+ Hits        38585    38712   +127     
  Misses        315      315            
  Partials       34       34            

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@PavelMakarchuk
Copy link
Collaborator

Could link the issue in the PR description?

Copy link
Contributor

@MaxGhenis MaxGhenis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this includes all the instances of this variable.

Note this modifies tests that appear to be unit tests (and therefore should also have had interest_expense in the underlying formula or parameter) but are not (they come from taxsim validation). I've filed #5587 to address this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rename interest_expense to deductible_interest_expense
3 participants