Correct Income Exclusion Order and FBR Comparison for SSI Spousal Deeming #5615

mexi-cano · 2025-02-18T18:29:16Z

Applied income exclusions to ineligible spouse's income first per §416.1163
Implemented correct order of operations: general exclusion ($20) → earned income exclusion ($65) → 50% remainder reduction
Added comparison logic against couple vs. individual FBR difference
Updated benefit calculation to follow SSI regulatory requirements

This resolves incorrect benefit calculations and ensures compliance with SSI regulations §416.1163 for spousal deeming cases.

…le income separately - 2. Compare it to the difference between couple and individual rates - 3. Only deem income if it exceeds that threshold - 4. Apply the correct deeming formula based on SSI regulations

codecov · 2025-02-18T20:36:28Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.07%. Comparing base (2b093e5) to head (bdeff6d).
Report is 53 commits behind head on master.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #5615      +/-   ##
==========================================
- Coverage   99.10%   99.07%   -0.03%     
==========================================
  Files        2695     2695              
  Lines       39028    38989      -39     
  Branches      173      171       -2     
==========================================
- Hits        38677    38630      -47     
- Misses        316      326      +10     
+ Partials       35       33       -2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

MaxGhenis

minor stylistic suggestions but adding pavel for a logic review

could you also link the issue?

MaxGhenis · 2025-02-18T23:34:39Z

...baseline/gov/ssa/ssi/eligibility/income/deemed/ssi_income_deemed_from_ineligible_spouse.yaml

+        age: 55
+        is_disabled: false
+        is_tax_unit_head: true
+        ssi_earned_income: 31080


and elsewhere

Suggested change

ssi_earned_income: 31080

ssi_earned_income: 31_080

do this everywhere

MaxGhenis · 2025-02-18T23:35:25Z

...eligibility/income/deemed/from_ineligible_spouse/ssi_income_deemed_from_ineligible_spouse.py

        )

-        return spousal_deemed_income * (spousal_deemed_income > person_rate)
+        return where(


Suggested change

return where(

return (is_eligible & has_ineligible_spouse) * deemed_income

MaxGhenis · 2025-02-18T23:35:41Z

policyengine_us/variables/gov/ssa/ssi/eligibility/status/is_ssi_ineligible_spouse.py

+
+        # Check if they're in a marital unit
+        in_marital_unit = person.marital_unit.any(
+            person("is_tax_unit_spouse", period)


Suggested change

person("is_tax_unit_spouse", period)

person("is_tax_unit_head_or_spouse", period)

mexi-cano · 2025-02-19T16:31:36Z

Updated with the requested changes. Linking issue here.

MaxGhenis · 2025-02-19T20:15:04Z

policyengine_us/variables/gov/ssa/ssi/eligibility/status/is_ssi_ineligible_spouse.py

+        # Check if they're in a marital unit
+        in_marital_unit = person.marital_unit.any(
+            person("is_tax_unit_head_or_spouse", period)
+            | person("is_tax_unit_head", period)


Suggested change

| person("is_tax_unit_head", period)

MaxGhenis · 2025-02-19T20:15:42Z

policyengine_us/variables/gov/ssa/ssi/eligibility/status/is_ssi_ineligible_spouse.py

@@ -10,7 +10,24 @@ class is_ssi_ineligible_spouse(Variable):
    reference = "https://www.law.cornell.edu/uscode/text/42/1382c#b"

    def formula(person, period, parameters):
-        spouse = person("is_tax_unit_spouse", period)
+        # Consider both tax unit spouse and tax unit head as potential spouses
+        is_spouse = person("is_tax_unit_spouse", period) | person(


just use person("is_tax_unit_head_or_spouse", period)

MaxGhenis · 2025-02-20T15:10:42Z

I mean https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

mexi-cano · 2025-02-20T16:06:09Z

I mean https://docs.github.com/en/issues/tracking-your-work-with-issues/using-issues/linking-a-pull-request-to-an-issue

Thanks! Should be linked now and pushed up an update.

MaxGhenis · 2025-02-20T16:29:33Z

policyengine_us/variables/gov/ssa/ssi/eligibility/status/is_ssi_ineligible_spouse.py

@@ -10,7 +10,21 @@ class is_ssi_ineligible_spouse(Variable):
    reference = "https://www.law.cornell.edu/uscode/text/42/1382c#b"

    def formula(person, period, parameters):
-        spouse = person("is_tax_unit_spouse", period)
+        # Consider both tax unit spouse and tax unit head as potential spouses
+        is_spouse = person("is_tax_unit_head_or_spouse", period)


Suggested change

is_spouse = person("is_tax_unit_head_or_spouse", period)

is_head_or_spouse = person("is_tax_unit_head_or_spouse", period)

MaxGhenis · 2025-02-20T16:29:48Z

policyengine_us/variables/gov/ssa/ssi/eligibility/status/is_ssi_ineligible_spouse.py

+
+        # Check if they're in a marital unit
+        in_marital_unit = person.marital_unit.any(
+            person("is_tax_unit_head_or_spouse", period)


Suggested change

person("is_tax_unit_head_or_spouse", period)

is_head_or_spouse

MaxGhenis · 2025-02-20T16:31:20Z

policyengine_us/variables/gov/ssa/ssi/eligibility/status/is_ssi_ineligible_spouse.py

+        # Consider both tax unit spouse and tax unit head as potential spouses
+        is_spouse = person("is_tax_unit_head_or_spouse", period)
+
+        # Check if they're in a marital unit


what's the purpose of this; won't it always be true? if they're themselves a head or spouse, their marital unit will have a head or spouse

…nt marital unit check.

MaxGhenis · 2025-02-20T19:21:24Z

policyengine_us/variables/gov/ssa/ssi/eligibility/status/is_ssi_ineligible_spouse.py

could you amend the corresponding test file to reflect the changes?

There is no existing test file for this (this was an existing file). I created ssi_income_deemed_from_ineligible_spouse.yaml instead to test the output.

MaxGhenis · 2025-02-20T21:11:21Z

Thanks I added @DTrim99 to review the logic. He's out of office tomorrow but will review next week. Could you resolve outstanding comments in the meantime?

mexi-cano · 2025-02-21T12:17:11Z

Thanks I added @DTrim99 to review the logic. He's out of office tomorrow but will review next week. Could you resolve outstanding comments in the meantime?

Thanks! I believe I've addressed all of the latest comments in the last update. Is there one I missed specifically?

mexi-cano added 5 commits February 17, 2025 19:34

Create unit test for SSI spousal deeming issue

0ab5602

Populate changelog_entry.yaml

5bd3127

Updated formula to 1. First calculate the ineligible spouse's countab…

31a7c96

…le income separately - 2. Compare it to the difference between couple and individual rates - 3. Only deem income if it exceeds that threshold - 4. Apply the correct deeming formula based on SSI regulations

Corrected yaml test file expected output values

ba7a2f6

ran make format

b9a89eb

mexi-cano mentioned this pull request Feb 18, 2025

Fix SSI Spousal Deeming: Correct Income Exclusion Order and FBR Comparison #5608

Open

MaxGhenis requested a review from PavelMakarchuk February 18, 2025 23:34

MaxGhenis requested changes Feb 18, 2025

View reviewed changes

Updated marital unit check for ineligible spouse and stylistic changes.

c609865

MaxGhenis reviewed Feb 19, 2025

View reviewed changes

MaxGhenis requested changes Feb 19, 2025

View reviewed changes

mexi-cano changed the title ~~Fix SSI Spousal Deeming: Correct Income Exclusion Order and FBR Comparison~~ Fixes #5608 SSI Spousal Deeming: Correct Income Exclusion Order and FBR Comparison Feb 20, 2025

Simplify spouse identification using is_tax_unit_head_or_spouse variable

0173917

mexi-cano requested a review from MaxGhenis February 20, 2025 16:06

MaxGhenis requested changes Feb 20, 2025

View reviewed changes

Simplify spouse identification reducing redundancies. Removed redunda…

bdeff6d

…nt marital unit check.

mexi-cano requested a review from MaxGhenis February 20, 2025 18:37

MaxGhenis reviewed Feb 20, 2025

View reviewed changes

MaxGhenis changed the title ~~Fixes #5608 SSI Spousal Deeming: Correct Income Exclusion Order and FBR Comparison~~ Correct Income Exclusion Order and FBR Comparison for SSI Spousal Deeming Feb 20, 2025

MaxGhenis requested review from DTrim99 and removed request for PavelMakarchuk February 20, 2025 20:25

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Correct Income Exclusion Order and FBR Comparison for SSI Spousal Deeming #5615

Correct Income Exclusion Order and FBR Comparison for SSI Spousal Deeming #5615

mexi-cano commented Feb 18, 2025 •

edited

Loading

codecov bot commented Feb 18, 2025 •

edited

Loading

MaxGhenis left a comment

MaxGhenis Feb 18, 2025

MaxGhenis Feb 19, 2025

MaxGhenis Feb 18, 2025

MaxGhenis Feb 18, 2025

mexi-cano commented Feb 19, 2025

MaxGhenis Feb 19, 2025

MaxGhenis Feb 19, 2025

MaxGhenis commented Feb 20, 2025

mexi-cano commented Feb 20, 2025

MaxGhenis Feb 20, 2025

MaxGhenis Feb 20, 2025

MaxGhenis Feb 20, 2025

MaxGhenis Feb 20, 2025

mexi-cano Feb 20, 2025

MaxGhenis commented Feb 20, 2025

mexi-cano commented Feb 21, 2025

	return where(
	return (is_eligible & has_ineligible_spouse) * deemed_income

	person("is_tax_unit_spouse", period)
	person("is_tax_unit_head_or_spouse", period)

	is_spouse = person("is_tax_unit_head_or_spouse", period)
	is_head_or_spouse = person("is_tax_unit_head_or_spouse", period)

	person("is_tax_unit_head_or_spouse", period)
	is_head_or_spouse

Correct Income Exclusion Order and FBR Comparison for SSI Spousal Deeming #5615

Are you sure you want to change the base?

Correct Income Exclusion Order and FBR Comparison for SSI Spousal Deeming #5615

Conversation

mexi-cano commented Feb 18, 2025 • edited Loading

codecov bot commented Feb 18, 2025 • edited Loading

Codecov Report

MaxGhenis left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

mexi-cano commented Feb 19, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MaxGhenis commented Feb 20, 2025

mexi-cano commented Feb 20, 2025

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

MaxGhenis commented Feb 20, 2025

mexi-cano commented Feb 21, 2025

mexi-cano commented Feb 18, 2025 •

edited

Loading

codecov bot commented Feb 18, 2025 •

edited

Loading