Modernization - May 2024 #16
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dbaty
force-pushed
the
dbaty/modernization
branch
3 times, most recently
from
7e7630d
to
c0a9c4c
Compare
Active support of Python 3.7 has ended in June 2020. Security support has ended in June 2023.
The "pyproject" extra dependency has been removed from isort 5.0.0,
which has been released in July 2020. It caused a warning with when a
more recent version was installed:
$ pip install -r requirements_dev.txt
[...]
WARNING: isort 5.13.2 does not provide the extra 'pyproject'
[...]
We maintained non-obvious code to support versions of Git that did not have the `--only-matching` option, which appeared in Git 2.19. This version was released in September 2018, it's time to move on.
That's where all tools are configured (except ReadTheDocs, which does not support `pyproject.toml`).
These checks seem useful, I don't know why they should disabled.
dbaty
force-pushed
the
dbaty/modernization
branch
from
f9bccf9
to
bf5b75f
Compare
It was not necessary with Python >= 3.11, which ships with the `tomllib` package in the standard library. Also, the extra requirement could be a bit confusing, especially for non-Python developers. "Do I need it now, will I need it later?" For the sake of simplicity, the extra requirement has been removed. We now always install `toml` on Python versions earlier than 3.11 (and never on 3.11 and above).
dbaty
force-pushed
the
dbaty/modernization
branch
2 times, most recently
from
622bed5
to
f40c3be
Compare
sandre35
reviewed
May 16, 2024
|
|
||
| # Template used to display messages. This is a python new-style format string | ||
| # used to format the message information. See doc for all details | ||
| msg-template="{path}:{line}: [{msg_id}({symbol}), {obj}] {msg}" |
There was a problem hiding this comment.
There is no copy of the REPORTS section. Is this done on purpose?
There was a problem hiding this comment.
Yes, this is intentional. I am switching to the default template for simplicity's sake. I find it readable enough: {path}:{line}:{column}: {msg_id}: {msg} ({symbol}). Example:
src/check_oldies/commands.py:33:4: W0612: Unused variable 'a' (unused-variable)
| @@ -0,0 +1,2 @@ | |||
| # TIMEBOMB: FEWTURE-BOOM1 | |||
| # FEWTURE-DO-NOT-REPORT: do not report, it's not within an annotation | |||
There was a problem hiding this comment.
J'ai bien envie de d'utiliser le terme FEWTURE premier degré maintenant 😄
| future_tag_regex=base.TESTING_FUTURE_TAG, | ||
| whitelist=(), | ||
| ) | ||
| assert tags == {"FEWTURE-BOOM1", "FEWTURE-BOOM2"} |
There was a problem hiding this comment.
Est-ce que le tag n'est pas TIMEBOMB ici ?
There was a problem hiding this comment.
Le tag cherché est bien de type "FUTURE-xxx".
"TIMEBOMB", c'est en fait un "FIXME". Peut-être que je devrais le nommer "FIIXME" dans les tests, ce sera plus proche de "FIXME" et donc plus clair.
dbaty
force-pushed
the
dbaty/modernization
branch
from
2877df3
to
f792408
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commits should be reviewed one by one.