Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement nested pack loading for folders and zipped packs #353

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Implement nested pack loading for folders and zipped packs #353

wants to merge 1 commit into from
+74 −27

Conversation

astrsh
Copy link
Member

@astrsh astrsh commented Jul 23, 2022 •
edited
Loading

Pull Request

Brief description.

What Issues Does This Fix?

Closes #352

Licensing

  • I am the original author of this code, and I am willing to release it
    under GPLv3.
  • I am not the original author of this code, but it is in public domain or
    released under GPLv3 or a
    compatible license.

Types of changes

  • Bug Fix
  • Build system
  • Documentation
  • New Feature
  • Performance
  • Refactoring
  • Repository
  • Revert
  • Style
  • Tests
  • Translation

Compatiblity

  • Breaking
    change
  • Non-Breaking change.

Contribution Guidelines.

  • I have read
    the CONTRIBUTING.md
    document in the root of the git repository.
  • My code follows the code style for this
    project.

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Testing

  • I have added tests to cover my changes.
  • All new and existing tests passed.

@astrsh
Implement nested pack loading for folders and zipped packs
970b7d9 
Does not include loading packs nested in zips
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dfsek dfsek Awaiting requested review from dfsek dfsek will be requested when the pull request is marked ready for review dfsek is a code owner

@solonovamax solonovamax Awaiting requested review from solonovamax solonovamax will be requested when the pull request is marked ready for review solonovamax is a code owner

@duplexsystem duplexsystem Awaiting requested review from duplexsystem duplexsystem will be requested when the pull request is marked ready for review duplexsystem is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] Recursively search packs directory for valid packs
1 participant
@astrsh