Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for allay platform #474

Merged
merged 61 commits into from
Oct 25, 2024

Conversation

smartcmd
Copy link

@smartcmd smartcmd commented Oct 14, 2024

Pull Request

Description

This PR add support for allay platform.

Changelog

  • Basic support
    • Block & item & biome mappings
  • Command delegation
  • Reloading support
  • Mapping generator

Checklist

Mandatory checks

  • The base branch of this PR is an unreleased version branch (that has a ver/ prefix)
    or is a branch that is intended to be merged into a version branch.
  • There are no already existing PRs that provide the same changes.
  • The PR is within the scope of Terra (i.e. is something a configurable terrain generator should be doing).
  • Changes follow the code style for this project.
  • I have read the CONTRIBUTING.md
    document in the root of the git repository.

Types of changes

  • Bug Fix
  • Build system
  • Documentation
  • New Feature
  • Performance
  • Refactoring
  • Repository
  • Revert
  • Style
  • Tests
  • Translation

Compatibility

  • Introduces a breaking change
  • Introduces new functionality in a backwards compatible way.
  • Introduces bug fixes

Documentation

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

Testing

  • I have added tests to cover my changes.
  • All new and existing tests passed.

Licensing

  • I am the original author of this code, and I am willing to
    release it under GPLv3.
  • I am not the original author of this code, but it is in public domain or
    released under GPLv3 or a compatible license.

Copy link
Member

@duplexsystem duplexsystem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for a few things:

Over all good work!

@smartcmd
Copy link
Author

Looks good except for a few things:

Over all good work!

  • All 'var' have been replaced with the explicit type
  • I'm not going to implement the remaining two features (command, additional biome options) as they are a bit difficult to implement now c:. However, config pack reloading should be easy to be done and I will implement it.

@duplexsystem
Copy link
Member

Looks good except for a few things:

Over all good work!

* All 'var' have been replaced with the explicit type

* I'm not going to implement the remaining two features (command, additional biome options) as they are a bit difficult to implement now c:. However, config pack reloading should be easy to be done and I will implement it.

Sounds good.

@duplexsystem
Copy link
Member

Is it possible to pin allay to a specific build instead of using the latest build for compiling?

@smartcmd
Copy link
Author

Is it possible to pin allay to a specific build instead of using the latest build for compiling?

image

Yes, I already did this c:

@duplexsystem
Copy link
Member

Ah sorry my git window had not refreshed since commit 8a6ad95

@smartcmd
Copy link
Author

Is there anything else that needs to be done?

@duplexsystem
Copy link
Member

No it will get merged in the next release cycle

@smartcmd smartcmd changed the title Add support for allay platform feat: add support for allay platform Oct 21, 2024
@duplexsystem duplexsystem changed the base branch from master to ver/6.6.0 October 25, 2024 22:05
@duplexsystem duplexsystem merged commit e56b885 into PolyhedralDev:ver/6.6.0 Oct 25, 2024
@solonovamax
Copy link
Member

should @smartcmd be added as a CODEOWNER for the allay platform?

@duplexsystem
Copy link
Member

Yes I think, we should also add @OakLoaf as a code owner for bukkit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants