-
Notifications
You must be signed in to change notification settings - Fork 87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support for allay platform #474
Conversation
… pos instead of chunk local pos
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for a few things:
- Are we excepting the TODOs to be done before merge?
- Is it possible to not use coding styles like 'var' for consistency with the rest of the code base?
- If Allay is trying to emulate minecraft (which it is) i'd recommend implementing the additional platform biome options using fabric as a reference see (https://github.com/PolyhedralDev/Terra/tree/master/platforms/mixin-common/src/main/java/com/dfsek/terra/mod/config) for consistency with other platforms.
Over all good work!
platforms/allay/src/main/java/org/allaymc/terra/allay/Mapping.java
Outdated
Show resolved
Hide resolved
platforms/allay/src/main/java/org/allaymc/terra/allay/AllayPlatform.java
Outdated
Show resolved
Hide resolved
platforms/allay/src/main/java/org/allaymc/terra/allay/generator/AllayGeneratorWrapper.java
Outdated
Show resolved
Hide resolved
platforms/allay/src/main/java/org/allaymc/terra/allay/TerraAllayPlugin.java
Outdated
Show resolved
Hide resolved
platforms/allay/src/main/java/org/allaymc/terra/allay/generator/AllayGeneratorWrapper.java
Outdated
Show resolved
Hide resolved
|
Sounds good. |
Is it possible to pin allay to a specific build instead of using the latest build for compiling? |
Ah sorry my git window had not refreshed since commit 8a6ad95 |
Is there anything else that needs to be done? |
No it will get merged in the next release cycle |
should @smartcmd be added as a CODEOWNER for the allay platform? |
Yes I think, we should also add @OakLoaf as a code owner for bukkit |
Pull Request
Description
This PR add support for allay platform.
Changelog
Command delegationMapping generatorChecklist
Mandatory checks
ver/
prefix)or is a branch that is intended to be merged into a version branch.
CONTRIBUTING.md
document in the root of the git repository.
Types of changes
Compatibility
Documentation
Testing
Licensing
release it under GPLv3.
released under GPLv3 or a compatible license.