Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bambda to Filter Authenticated Requests #59

Merged
merged 4 commits into from
Feb 6, 2024
Merged

Bambda to Filter Authenticated Requests #59

merged 4 commits into from
Feb 6, 2024

Conversation

joe-ds
Copy link
Contributor

@joe-ds joe-ds commented Feb 5, 2024

Bambda Contributions

  • Bambda has a valid header, featuring an @author annotation and suitable description
  • Bambda compiles and executes as expected
  • Only .bambda files have been added or modified (README.md files are automatically updated / generated after PR merge)

This is a Bambda to filter 200 OK authenticated requests. It has four variables near the top. By default it looks for Authorization headers, but setting a session cookie name (and optionally value) means it also checks for these.

portswigger-penguin
portswigger-penguin reviewed Feb 5, 2024
View reviewed changes
Proxy/HTTP/FilterAuthenticated.bambda Outdated Show resolved Hide resolved
Proxy/HTTP/FilterAuthenticated.bambda Outdated Show resolved Hide resolved
Proxy/HTTP/FilterAuthenticated.bambda Outdated Show resolved Hide resolved
Proxy/HTTP/FilterAuthenticated.bambda Outdated Show resolved Hide resolved
portswigger-penguin
portswigger-penguin reviewed Feb 6, 2024
View reviewed changes
Copy link

@portswigger-penguin portswigger-penguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. Just a few more minor comments on the changes. I think it is pretty much there.

Proxy/HTTP/FilterAuthenticated.bambda Outdated Show resolved Hide resolved
Proxy/HTTP/FilterAuthenticated.bambda Outdated Show resolved Hide resolved
Proxy/HTTP/FilterAuthenticated.bambda Outdated Show resolved Hide resolved
portswigger-penguin
portswigger-penguin requested changes Feb 6, 2024
View reviewed changes
Copy link

@portswigger-penguin portswigger-penguin left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve once the config variables are at the top of the file.

Proxy/HTTP/FilterAuthenticated.bambda Outdated Show resolved Hide resolved
Hannah-PortSwigger
Hannah-PortSwigger approved these changes Feb 6, 2024
View reviewed changes
Copy link
Contributor

@Hannah-PortSwigger Hannah-PortSwigger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your efforts! Looks good 👍

@Hannah-PortSwigger Hannah-PortSwigger merged commit 5455561 into PortSwigger:main Feb 6, 2024
1 check passed
@joe-ds
Copy link
Contributor Author

joe-ds commented Feb 6, 2024

Thank you for your very helpful corrections and patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@portswigger-penguin portswigger-penguin portswigger-penguin approved these changes

@Hannah-PortSwigger Hannah-PortSwigger Hannah-PortSwigger approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joe-ds @Hannah-PortSwigger @portswigger-penguin